Comments (3)
@ajkr Do you have any additional insight as to the benefit of concurrent flushes? The same criticisms I have for concurrent compactions apply here, but more so as we're not talking about compactions at different levels. I suppose if flushes are CPU limited, concurrent flushes will allow more throughput, but I haven't seen any evidence of flushes being CPU limited. Concurrent flushes would have the side effect of consuming more CPU and thus slowing down the rate at which memtables are filling, but I think other more direct mechanisms to adjust the pace of user writes would be preferable. Is there anything I'm missing here?
from pebble.
Right I think that's the idea - it can help if flushes are CPU bound by parallelizing the work. If they're not CPU bound, or the memtable fill rate is slower than the flush rate, seems it wouldn't help. I can't recall any specific cases where it helped, though it's been baked into RocksDB forever so it's hard to know who is benefiting from it.
from pebble.
Ok. I'm going to close this issue as I suspect it isn't worthwhile and I can't see us investigating it further any time soon. Concurrent compactions are a different matter which still requires investigation.
from pebble.
Related Issues (20)
- db: avoid loading skiplist size during concurrent apply HOT 2
- replay: add support for capturing and replaying read operations
- meta: add metamorphic CPU work granter HOT 1
- meta test failure HOT 3
- db: avoid loading later files for a level in SeekPrefixGE
- internal/metamorphic/crossversion/crossversion_test: TestMetaCrossVersion failed
- : failed HOT 1
- TestIteratorErrors fails with SeekLT violates upper bound panic HOT 8
- github.com/cockroachdb/pebble/internal/metamorphic: TestMeta failed HOT 6
- : failed HOT 5
- github.com/cockroachdb/pebble/internal/metamorphic: TestMetaTwoInstance failed HOT 6
- github.com/cockroachdb/pebble/internal/metamorphic: TestMeta failed HOT 3
- : failed HOT 1
- : failed HOT 2
- github.com/cockroachdb/pebble/internal/metamorphic: TestMeta failed HOT 15
- : failed HOT 9
- external ingest: fix bloom filters when synthetic prefix is used
- loong64 arch undefined array length maxArrayLen or missing type constraint
- : failed HOT 14
- Column family is a very useful feature. possible to implement this? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pebble.