Giter VIP home page Giter VIP logo

Comments (3)

petermattis avatar petermattis commented on July 1, 2024

@ajkr Do you have any additional insight as to the benefit of concurrent flushes? The same criticisms I have for concurrent compactions apply here, but more so as we're not talking about compactions at different levels. I suppose if flushes are CPU limited, concurrent flushes will allow more throughput, but I haven't seen any evidence of flushes being CPU limited. Concurrent flushes would have the side effect of consuming more CPU and thus slowing down the rate at which memtables are filling, but I think other more direct mechanisms to adjust the pace of user writes would be preferable. Is there anything I'm missing here?

from pebble.

ajkr avatar ajkr commented on July 1, 2024

Right I think that's the idea - it can help if flushes are CPU bound by parallelizing the work. If they're not CPU bound, or the memtable fill rate is slower than the flush rate, seems it wouldn't help. I can't recall any specific cases where it helped, though it's been baked into RocksDB forever so it's hard to know who is benefiting from it.

from pebble.

petermattis avatar petermattis commented on July 1, 2024

Ok. I'm going to close this issue as I suspect it isn't worthwhile and I can't see us investigating it further any time soon. Concurrent compactions are a different matter which still requires investigation.

from pebble.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.