Giter VIP home page Giter VIP logo

shareinspector's People

Contributors

ole avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

shareinspector's Issues

Layout issues with multiline text and cell reuse(?)

Some table cells with text (TextCell) are not always laid out correctly. This seems to happen especially when a cell is reused and its new content is longer (more lines) than it was before. But I'm also seeing it when I rotate an iPhone from portrait to landscape, which shouldn't trigger cell reuse as far as I know.

Steps to reproduce:

  1. Select a number of photos in Photos.app (10 to 20) and share them to Share Inspector.

    Ideally, there should be a few HEIC and Live Photos in the mix because those will cause Photos to provide multiple type identifiers, making the registeredTypeIdentifiers field multiline.

  2. Scroll through the table and observe the cell layout. Is everything correct?

  3. Rotate the device from portrait to landscape? Are cell layouts correct after rotation?

I added a hack that a cell gets reloaded (hopefully triggering relayout) when you tap it, but that's not a good solution.

IMG_3160

Truncated error message when preview image can't be loaded

Cell layout isn't correct when the infoLabel in ImageCell is long/has multiple lines.

Steps to reproduce to see the error:

  1. Open Safari in iOS 13 and open a web page.
  2. Open the share sheet and tap Options > Send as PDF
  3. Share to Share Inspector. The preview image cell displays an error with a truncated error message.

IMG_0041

Collapse/Expand button in userInfo row doesn't animate nicely

The animation from the Expanded to the Collapsed state is broken. The "header elements" (the "userInfo" label and the Collapse/Expanse button) should stay where they are and only the content label should shrink. Instead, the header elements jump to the bottom of the cell and then animate up as the content label shrinks.

Can't load preview images for shared PDFs

Steps to reproduce:

  1. Open Safari in iOS 13 and open a web page.
  2. Open the share sheet and tap Options > Send as PDF
  3. Share to Share Inspector. The preview image cell displays an error.

(See #1 for a screenshot.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.