The last 4 sorted elements from solution are:
{'First Name': 'Raj', 'Last Name': 'Sharma'}
{'First Name': 'Raj', 'Last Name': 'Nayyar'}
{'First Name': 'Raj', 'Last Name': 'Thakur'}
{'First Name': 'Suraj', 'Last Name': 'Sharma'

but alphabetically, 'Nayyar' should come before 'Sharma'.

The attached code below gives the desired o/p.
exercise_selection_sort.txt

Instead of linearly searching for all the occurrences we could do that faster by searching them all in a binary way.

Here:

while i >=0:
    if numbers[i] == number_to_find:
        indices.append(i)
    else:
        break
    i = i - 1

And here:

while i<len(numbers):
    if numbers[i] == number_to_find:
        indices.append(i)
    else:
        break
    i = i + 1

I would be happy to make a pull request 😄

PS: Your tutorial playlist on DSA is amazing!

Correct URL: https://github.com/codebasics/data-structures-algorithms-python/blob/master/algorithms/2_BubbleSort/bubble_sort_exercise_solution.py

Current URL: https://github.com/codebasics/data-structures-algorithms-python/blob/master/algorithmsAlgorithms/2_BubbleSort/bubble_sort_exercise_solution.py

7_SelectionSort/selection_sort_exercise_solution.py

The code in this file gives incorrect order of anwer conflicting with the correct order in the corresponding .md file.

The code gives this:

{'First Name': 'Aahana', 'Last Name': 'Arora'}
{'First Name': 'Armaan', 'Last Name': 'Dadra'}
{'First Name': 'Armaan', 'Last Name': 'Kumar'}
{'First Name': 'Ingrid', 'Last Name': 'Galore'}
{'First Name': 'Ingrid', 'Last Name': 'Maverick'}
{'First Name': 'Jade', 'Last Name': 'Canary'}
{'First Name': 'Jaya', 'Last Name': 'Seth'}
{'First Name': 'Jaya', 'Last Name': 'Sharma'}
{'First Name': 'Karan', 'Last Name': 'Kumar'}
{'First Name': 'Kiran', 'Last Name': 'Kamla'}

{'First Name': 'Raj', 'Last Name': 'Sharma'}
{'First Name': 'Raj', 'Last Name': 'Nayyar'}

{'First Name': 'Raj', 'Last Name': 'Thakur'}
{'First Name': 'Suraj', 'Last Name': 'Sharma'}

But, it's supposed to be:

[
{'First Name': 'Aahana', 'Last Name': 'Arora'}
{'First Name': 'Armaan', 'Last Name': 'Dadra'}
{'First Name': 'Armaan', 'Last Name': 'Kumar'}
{'First Name': 'Ingrid', 'Last Name': 'Galore'}
{'First Name': 'Ingrid', 'Last Name': 'Maverick'}
{'First Name': 'Jade', 'Last Name': 'Canary'}
{'First Name': 'Jaya', 'Last Name': 'Seth'}
{'First Name': 'Jaya', 'Last Name': 'Sharma'}
{'First Name': 'Karan', 'Last Name': 'Kumar'}
{'First Name': 'Kiran', 'Last Name': 'Kamla'}

**_{'First Name': 'Raj', 'Last Name': 'Nayyar'}
{'First Name': 'Raj', 'Last Name': 'Sharma'}_**

{'First Name': 'Raj', 'Last Name': 'Thakur'}
{'First Name': 'Suraj', 'Last Name': 'Sharma'}

]

Deletion not happening when there is only one node. The code should go like this:
tree = tree.delete(17)

Case: Key exists after the first empty slot.
Issue: Code inserts the new (key,value) instead of updating existing (key,value).

Code in question:
def find_slot(self, key, index):
        prob_range = self.get_prob_range(index)
        for prob_index in prob_range:
            if self.arr[prob_index] is None:
                return prob_index
            if self.arr[prob_index][0] == key:
                return prob_index
        raise Exception("Hashmap full") ```
Maybe this can fix it:
def find_slot(self, key, index):
        first_slot = None
        prob_range = self.get_prob_range(index)
        for prob_index in prob_range:
            if first_slot == None and self.arr[prob_index] is None:
                first_slot = prob_index
            if self.arr[prob_index][0] == key:
                return prob_index
        if first_slot is not None:
           return first_slot
        raise Exception("Hashmap full")

https://github.com/codebasics/data-structures-algorithms-python/blob/master/data_structures/3_LinkedList/Solution/singly_linked_list_exercise.py

Proposed below :

        if not self.head:
            return

        if self.head.val == value:
            self.head = self.head.next
            return

        itr = self.head
        prev_node = None
        while itr:
            if itr.val == value:
                prev_node.next = itr.next
            prev_node = itr
            itr = itr.next

https://github.com/codebasics/data-structures-algorithms-python/blob/master/data_structures/6_Queue/Exercise/food_ordering_system.py

Issue:

def serve_orders():
    time.sleep(1)
    while True:
        order = food_order_queue.dequeue()
        print("Now serving: ",order)
        time.sleep(2)

Proposed below:

def serve_orders():
    time.sleep(1)
    while not food_order_queue.is_empty():
        order = food_order_queue.dequeue()
        print("Now serving: ",order)
        time.sleep(2)

How do you reduce a price after getting a refund..? (In Last Question)

In collision Handling , in the chaining method we have stored the value in the form form tuple inside the linked list so it means it must be immutable but when i try to execute the code and update that key then the value which is returned is different but your repo the value isnt changed can you help me with this disparity

the code isnt running properly and it is giving me attribute error, even though i have typed the same code as the one given .... in total it is giving me error on lines 13, 91, 97.... what can i do to fix this....

In Collision Handling in HAsh Table march 17 returns value 59 instead of 9 when we apply hash function to it

Even though I save the file in the same location it still raises an error.

The tutorial was excellent but this code is incomplete and not working correctly.

max = int(input("Enter max number: "))

odd_numbers = []

for i in range(1, max):
if i % 2 == 1:
odd_numbers.append(i)

print("Odd numbers: ", odd_numbers)

The loop is Executed 0(n) times we can reduce as 0(n/2)

whenever Exception condition is fulfilled, the program exits and could not run further code. How can we make the program to run even after Exception condition is raised?

https://github.com/codebasics/data-structures-algorithms-python/blob/master/data_structures/6_Queue/Exercise/binary_numbers.py

Issue:

def produce_binary_numbers(n):
    numbers_queue = Queue()
    numbers_queue.enqueue("1")

    for i in range(n):
        front = numbers_queue.front()
        print("   ", front)
        numbers_queue.enqueue(front + "0")
        numbers_queue.enqueue(front + "1")

        numbers_queue.dequeue()

Proposed below:

def produce_binary_numbers(n):
    numbers_queue = Queue()
    numbers_queue.enqueue("1")
    i = 0
    while i < n//2 and not numbers_queue.is_empty():
        i+=1
        front = numbers_queue.dequeue()
        print(front)
        numbers_queue.enqueue(front + "0")
        numbers_queue.enqueue(front + "1")
        
    while not numbers_queue.is_empty() and i<n:
        print(numbers_queue.dequeue())
        i+=1

There is an error in the dequeue method in the Queue class as when I'm running this program
food_ordering_system.py . I'm getting an infinite loop

Placing order for: samosa
Placing order for:Now serving:  pizza
 pasta
Placing order for: biryani
Placing order for: burger
Now serving:  samosa
Now serving:  pasta
Now serving:  biryani
Now serving:  burger
Queue is empty
Now serving:  None
Queue is empty
Now serving:  None
Queue is empty
Now serving:  None
Queue is empty
Now serving:  None
Queue is empty
Now serving:  None
Queue is empty
Now serving:  None 

and it goes on
I think this error can be solved by using the try and except block
I'm new to open source and trying to make my contribution.
I will work on this issue.
can you guide me?

If self.right is None:
return self.left #64 line