codeconsortium / ccdnuserprofilebundle Goto Github PK

The UserModel defines a generic find-method which can be used to find profiles on id as well as username. The issue is that it needs to decide whether to find on either of these criteria, and it can do so wrongly.

The easiest example is a user with the name 0xbad1dea. When entered as a parameter to the find method, the method will throw a tantrum. The same can be achieved with users with integer names.

Personally, I'd change the find method to accept only one criteria, but people might be relying on URLs such as /en/profile/tom to return something.

The documentation mentions Symfony 2.1.x is required, but composer.json requires 2.4.*. This requirement is mentioned in README.md and in Resources/doc/index.md

Whilst installing this bundle, I received the error:

[Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]               
The service "ccdn_user_profile.gateway.user" has a dependency on a non-existent service  
"knp_paginator".

Although the paginator bundle is a dependency, I think it needs to be registered as a bundle in app/AppKernel.php before it registers its services

I've noticed some odd behaviour in the UserModel, whilst looking to improve code coverage: whenever User entities are retrieved through the UserModel, the retrieval method (!) checks if the User has a profile and, if not, creates the profile on the fly.
This seems like unrelated behaviour to the UserModel, and should really be removed.