codecrafters-io / build-your-own-grep Goto Github PK

The your_grep.sh is not passing arguments with spaces correctly to stack.

Suppose our app is just this little program:

module Main where

import System.Environment

main :: IO ()
main = do
  args <- getArgs
  putStrLn $ show args

With the current your_grep.sh we'll get the following output:

> ./your_grep.sh -E "b r"
["-E","b","r"]

If we change your_grep.sh from...

exec stack run --silent -- $@

...to (note the double quotes)...

exec stack run --silent -- "$@"

...then we get something more useful:

> ./your_grep.sh -E "b r"
["-E","b r"]

The current reference solution has a little unwords hack to deal with this after the fact. The above change would not cause the reference solution to fail, though. The unwords call would just be redundant.

@rohitpaulk what do you think?