codeforcauseorg / pledge Goto Github PK

just for demo

I checked the code of this project and by cross-checking the list of the contributors JSON file with the displayed cards on the site, I realized that the cards are structured by the alphabetic ordering of the name of their respective JSON file. That means, say Shubham.json is displayed first then ayush.json because "capital S" is greater than "small a" in ASCII encoding.

I made a contribution to this project a day ago and I saved my JSON file with the name suyash.json. I went to the site to check my profile card. I was confused that my profile card was not mentioned even in the part where cards with the name S were starting. I scrolled further and cards with the name starting with A again started to appear. Following that, cards with the name starting with b, c, d, etc were listed. Almost at the very last of the page, I found my card.

This can cause confusion among beginners and they might even open a pull request saying "My profile card is not displayed". The number of contributors who took the pledge is about to reach 200 and I think this can happen. In fact, I was about to open an issue too.

I think cards should be arranged in alphabetical order without being case-sensitive. It should be arranged like that regardless of whether the contributor saves their JSON file with a capital letter or not. And a side note should be there on the website saying something like "Cards are arranged in the alphabetical order of contributors name" after this issue is fixed.

Alternatively, we can just take care of the upcoming contribution by adding one more point in the create_pledge.md file stating that the JSON file must be named with only the first letter being capital so that the upcoming contributions are structured. But this would leave already made contributions unstructured.

Checking whether the first letter of the JSON file is capital or not during the time of PR can be automated with integration testing which is already in place. I am not sure about this though.

Thanks for reading! 😊

Bug: Demo bug, something not working as expected

Refactor codebase and use component-based architecture instead of adding whole code in a single file. Currently, the whole code is in and single file which makes the code a bit messy and confusing for new contributors.

Additional context

we can do this by making different components(ex: header component, footer component) and use them in the main code file. This makes code clean and efficient, and it also provides a better understanding of code to the new contributors.

we can also make separate CSS files for each component which provides more clarity to the new contributors.

Describe the issue
Add pagination feature for displaying pledge cards. It should display 39 cards/page (i.e. 13*3, 3 cards in a row) with all the pages mentioned below.

Currently avatar can be selected from only stock images. An option can be provided to choose which social media platform to pull avatar from (GitHub / Twitter / LinkedIn).

This is test issue. I have watched your tutorial and try to make a issue. Thanks.

Demo bug ,something not working as intended

I want to preview the project as the README.md directed, I ran all commands that i was supposed to, or at least all that i could. I saw somewhere that i can't use nvm on my windows computer so i couldn't run the command(s) that involved it.

0 info it worked if it ends with ok
1 verbose cli [
1 verbose cli   'C:\\Program Files (x86)\\nodejs\\node.exe',
1 verbose cli   'C:\\Program Files (x86)\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'serve'
1 verbose cli ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'preserve', 'serve', 'postserve' ]
5 info lifecycle [email protected]~preserve: [email protected]
6 info lifecycle [email protected]~serve: [email protected]
7 verbose lifecycle [email protected]~serve: unsafe-perm in lifecycle true
8 verbose lifecycle [email protected]~serve: PATH: C:\Program Files (x86)\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;C:\Users\OLUMIDE\Desktop\pledge\node_modules\.bin;C:\Users\OLUMIDE\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\local\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\OLUMIDE\bin;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\iCLS;C:\Program Files\Intel\Intel(R) Management Engine Components\iCLS;C:\windows\system32;C:\windows;C:\windows\System32\Wbem;C:\windows\System32\WindowsPowerShell\v1.0;C:\windows\System32\OpenSSH;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\WiFi\bin;C:\Program Files\Common Files\Intel\WirelessCommon;C:\Program Files\Git\cmd;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\nodejs;C:\Program Files\Microsoft VS Code\bin;C:\flutter\bin;C:\Users\OLUMIDE\AppData\Local\Android\Sdk\platform-tools;C:\Users\OLUMIDE\AppData\Local\Programs\Python\Python37\Scripts;C:\Users\OLUMIDE\AppData\Local\Programs\Python\Python37;C:\Users\OLUMIDE\AppData\Local\Microsoft\WindowsApps;C:\Program Files\Microsoft VS Code\bin;C:\Users\OLUMIDE\AppData\Roaming\npm;?C;C:\Program Files\Git\flutter\bin;C:\Program Files\PostgreSQL\12\bin;C:\Program Files\PostgreSQL\12\data;C:\flutter\bin;C:\Users\OLUMIDE\AppData\Local\Android\Sdk\platform-tools;C:\Users\OLUMIDE\AppData\Local\Android\Sdk\emulator;C:\Program Files\heroku\bin;C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Git\usr\bin\vendor_perl;C:\Program Files\Git\usr\bin\core_perl
9 verbose lifecycle [email protected]~serve: CWD: C:\Users\OLUMIDE\Desktop\pledge
10 silly lifecycle [email protected]~serve: Args: [ '/d /s /c', 'gatsby serve' ]
11 silly lifecycle [email protected]~serve: Returned: code: 7  signal: null
12 info lifecycle [email protected]~serve: Failed to exec serve script
13 verbose stack Error: [email protected] serve: `gatsby serve`
13 verbose stack Exit status 7
13 verbose stack     at EventEmitter.<anonymous> (C:\Program Files (x86)\nodejs\node_modules\npm\node_modules\npm-lifecycle\index.js:332:16)
13 verbose stack     at EventEmitter.emit (events.js:210:5)
13 verbose stack     at ChildProcess.<anonymous> (C:\Program Files (x86)\nodejs\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:210:5)
13 verbose stack     at maybeClose (internal/child_process.js:1028:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
14 verbose pkgid [email protected]
15 verbose cwd C:\Users\OLUMIDE\Desktop\pledge
16 verbose Windows_NT 10.0.17763
17 verbose argv "C:\\Program Files (x86)\\nodejs\\node.exe" "C:\\Program Files (x86)\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "serve"
18 verbose node v13.1.0
19 verbose npm  v6.12.1
20 error code ELIFECYCLE
21 error errno 7
22 error [email protected] serve: `gatsby serve`
22 error Exit status 7
23 error Failed at the [email protected] serve script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 7, true ]

Above is the complete log from the run

I am learning how to use git and github through the video on ur code for cause youtube channel. I would like to add my profile to it too.

I am learning:mag: how to use git and Git hub through the video on your CFC youtube channel.
I would like to add my profile to it too.:smiley:

Hey, I am new to open source and looking forward to becoming a valuable part of this community.
#My first PR

src/data/contributors/saksham.json
src/data/contributors/Saksham.json

while cloning the repo on Windows only one of these two files are saved..
temporary soln
A better solution would be to name a file with your full name

Creating a readme file which involves all steps for a student who is making his/her first contribution,as readme.md is not as detailed.

Description

When I open the site Pledge, there is a delay in loading CSS.
It takes close to 1s to load the CSS.

In this project, we can add a sort button to sort the contributors on different aspects.

Add an interactive loader that matches with the current theme of the webpage.