codeinwp / feedzy-rss-feeds Goto Github PK

https://secure.helpscout.net/conversation/347305627/130210/?folderId=212392

User said this:

"Hi, I use FEEDZY RSS and i really like it. Suggested update for the plug in is to make it available that the main link could be a audio file. i did the following edit: feedzy-rss-feeds/feedzy-rss-feeds-shortcode.php

$contentTitle .= '<span class="title"><a href="' . $item->get_permalink() . '" target="' . $target . '">'; $contentTitle .= '<audio controls style=" width:180px"> <source src="' . $item->get_permalink() . '" type="audio/mpeg"> </audio><br>';

works even better now! - so people can play the podcast right in the sidebar"

http://themeisle.com/plugins/feedzy-rss-feeds/

@ineagu what do you think of styling the grid to be more responsive ?

A feature to sort feeds by their titles/author or anything. Suggested by a user. @selul

http://docs.themeisle.com/article/277-feedzy-rss-feeds-hooks

So the plugin, for obvious reasons, can't load HTTP images on a HTTPS website, and that's not plugin's fault. But I have a workaround for this and maybe we can add that to the plugin?

If the site is running on HTTPS and someone tries to fetch a feed which is over HTTP, can we pull the images and display it using a CDN over HTTPS?

@selul @ineagu

Now that we have a separate SimplePie util class, maybe we can investigate how we can solve the warning when the cache directory is not writable,
Ref:
https://wordpress.org/support/topic/class-simplepie-php/

The approach which I would like to use

1. Check if the default cache location is writable if is return that and bail.
2. If is not, use a directory inside the uploads folder, called feedzy-cache, you can use -> http://simplepie.org/wiki/reference/simplepie/set_cache_location
3. if 2 is not possible ( can not create the folder or something similar ), use this to disable cache at all -> http://simplepie.org/wiki/reference/simplepie/enable_cache

Let me know what do you think about this ?

Also, if you find any patterns that we can cover using unit tests, go for them.

@selul

This is a feature request. To have pagination feature in free/pro plugin.
Sample: https://wordpress.org/plugins/fetch-feed-shortcode-pageable/

It is different but relevant to this issue - #79

putem pune fixul in releasul urmator.
https://wordpress.org/support/topic/feedzy-incorrectly-converts-spaces-in-image-url-to-dashes/

Yea, the title sums it up. :p

@selul
According to my conversation here: https://wordpress.org/support/topic/default-image-problem/ I found no way to use the custom image if the feed has a default image. I mean, the feed url is: https://katikitti.com/feed/

When I use thumb="yes" or thumb="auto" in the shortcode,

I can see the default images from the feed.

But When I use thumb="no". There is no image used.

Is there any way to display the image we want to display, even if the feed has a image?

@contactashish13 it seems many users are requesting a full text parse solution, something that will fetch article content directly from the link, not from the RSS feed.

In order to do this, we will need a 3rd party server that will act as a middleware.

Basically, the server will receive a list of RSS feeds and will return RSS feed resources with all the items combined, but instead of the feed content, it will get the article full content.

We will need to use a 3rd party library to make the process work smoother.

Here is an example that I found out, I'm open to any other suggestions
https://github.com/Dither/full-text-rs

Also, we will need to have an authentication service, because every call to this middleware server will have the license string and it will check the license against themeisle.com.

On the 1st phase, I would like for you to do a bit of research for the best alternative to do this and after we can move forward with the work.

Thanks!

when using feeds from google news, and the user is using the max attribute within the shortcode which is greater than the num query argument of the news feed, the feed is still limited to the num query arg,

E.g [feedzy-rss feeds="http://news.google.com/news?hl=en&gl=us&q=Tourette&num=20&um=1&ie=UTF-8&output=rss" max="30" target="_blank" refresh="1_hours" title="120" meta="yes" summary="yes" summarylength="275" size="160"]

because num=20 the max=30 is ignored as we dont have more than 20 items in the feed.

We should do a smart feed convert, which alter the num query arg if the google news feed is used.

ref: https://secure.helpscout.net/conversation/577848228/161185?folderId=1362294

We need to add $item to filters so that the SimplePie_Item object can be used

• In http://docs.themeisle.com/article/573-how-to-move-feedzy-templates-to-your-theme, add an example specifying the name of a popular theme so that its easy for users to understand. Remove abstract language.

• Review and update http://docs.themeisle.com/article/540-what-hooks-and-filters-are-available-in-feedzy with more explanation similar to http://docs.themeisle.com/article/663-what-actions-and-filters-are-available-in-pirate-forms

@preda-bogdan as we discussed let's introduce number of items per row to the pro settings, from 1-6

The RSS URL is https://kcsmoraleja.isams.co.uk/modules/newsmanager/feeds/rss/ which has been verified as a working RSS feed. However, it does not seem to load on our test website.

All users can access to Import Feed post type from admin menu: https://s.nimbus.everhelper.me/share/1388099/82tf4sfz7npyuuhhd7ea

Even if you're on personal plan. @selul

@bogdanpopa90 when you have a bit of free time please change the cover image and the icon here:

https://wordpress.org/plugins/feedzy-rss-feeds/

the icon should be on white background not blue as now and the cover looks a bit too low quality.

@selul

This is not a confirmed bug, however, I wanted to ask if we need to remove the plugin data while plugin deletion.

Reference: https://wordpress.org/support/topic/data-left-after-uninstall/

I deleted the plugin from my local and it kept all the data such as feed category and all.

Please close if we are not removing plugin data intentionally.

Feed isn't able to fetch the image when the there's no proper format. Few feeds have thumbnails as: http://website.com/feeditem/thumb/ instead of having a format. Can this work?

@selul

• add an editable template
• Download images
• Add tabs if multiple feeds are added
• Paramètre REL
• Type de contenu dédié
• Custom CSS
• Numérotation (list OL)
• WooComerce (product price)

If you use the Site Origin's Page Builder, the shortcode button doesn't work. It opens a modal with tags and doens't let you do anything. @selul

seo-friendly titles/description

We need to talk to @mariusghitulescu for this

@preda-bogdan the max number of items does not seems to work, is always fetching 5 items.

I have tried this code:
[feedzy-rss feeds="http://themeisle.com/blog/feed" maximum="2" ]

And is showing still 5 items

Author URL in feeds in adding http twice, like:

href="http://http://www.example.com"

We can remove one http but it doesn't make any sense if the site is running over https, so it's better to leave it // instead of defining a protocol.

In some places, we are using alt with span which makes no sense. Sending a pull to replace alt tags with title.

Fix compatibility with SiteOrigin Page Builder.

Still shows a blank (white page) when you try to edit options.

Function feedzy_return_image (in feedzy-rss-feeds-admin-abstract.php) scrapes only the first <img>, and if it is blacklisted, no image is returned. To fix this change this code:

    preg_match( $pattern, $img, $matches );
    if ( isset( $matches[0] ) ) {
        $blacklistCount = 0;
        foreach ( $matches as $matche ) {
            $link      = $this->feedzy_scrape_image( $matche );

to

    preg_match_all( $pattern, $img, $matches );
    if ( isset( $matches[0] ) ) {
        foreach ( $matches[0] as $matche ) {
            $blacklistCount = 0;
            $link      = $this->feedzy_scrape_image( $matche );

This goes through every <img> and returns first that is not blacklisted.

@contactashish13 i would like to add a general settings page, under the Feedzy main menu.

this will provide 4 fields which will be used when fetching the feed content:

1. User agent - add a input field for allowing users to add custom user agents. The user agent will be set in this function

   feedzy-rss-feeds/includes/abstract/feedzy-rss-feeds-admin-abstract.php

   Line 363 in 4e64b0f

   public function fetch_feed( $feedURL, $cache = '12_hours' ) {

   and using the http_headers_useragent filter. Make sure after the fetch is done, to remove the function hooked to that filter in order to avoid problems with other requests.
2. Proxy settings, proxy host, port user and password . you need to setup the some constants to use proxies, you have them detailed here: https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-http-proxy.php as well as hooking into pre_http_send_through_proxy fitering for allowing using proxy only for that specific url and not other. Also when defining the constans you need to make sure those were not defined before.

I don't quite understand what the user is saying here (not much knowledge on the plugin yet) but you could follow here: https://wordpress.org/support/topic/keyword-filtering-failure?replies=3#post-8810650

@selul

I installed the plugin, skipped the tracking option and the plugin appears in the footer of my Plugins.php in Dashboard: https://nimbus.everhelper.me/client/notes/share/954539/znh3reocuxfxd2509qte

It was half hidden inside admin menu but adding margin to show for this issue.

Note: Plugin originally developed by Brice CAPOBIANCO, b-website.com

@preda-bogdan using the wordpress 4.7 i get this error. Can you please check:

http://prntscr.com/djem5l

I saw that they recommend to use https://codex.wordpress.org/Function_Reference/fetch_feed

@contactashish13 we need to add a sorting attribute to the Feedzy shortcode.

1. Add the sorting order in the Feedzy popup in the WordPress editor.
2. The options will be name_asc, name_desc, date_asc, date_desc. The default will be the current order.
3. You can check this on how we can achieve this custom order, maybe it helps -> http://simplepie.org/wiki/reference/simplepie/sort_items
4. Make sure this change will not affect older users, by changing the order of their items.

@selul here I think we can better use button instead of tags : https://demo.themeisle.com/feedzy-rss-feeds/shop-feed/ , the main advantage is that it will get styled as the theme.

Medium feed not working with the plugin: https://medium.com/feed/topic/cryptocurrency.

As Medium is quite famous, it will be helpful if this can be resolved. Ticket: https://secure.helpscout.net/conversation/504029535/152078/

@selul

If image title contains a quote then it's breaking the HTML. PR coming up.

When we place a feed URL without http/https, it does not work. Example: themeisle.com/blog/feed.

It would be a good to have this feature to add http/https automatically if URL provided by the user is not having it.

@selul

https://wordpress.org/support/topic/one-broken-link-ruins-entire-feed/

i would like to add a new attribute to the shortcode, called refresh which will handle the the cache lifetime.

In the wizzard shortcode builder we will have a select for choose between ( 10_mins, 1_hours, 3_hours, 12hours, 1_days, 15_days) but when editing the shortcode inline, they can add combination of number + _ + unit where number can be anything between 1-100 and unit can be mins,hours,days

We need to validate the shortcode attribute value against this format, explode after _ and see if the 1st part is a number between 1-100 and 2nd is a valid unit between those 3.

The feed cache will be change using this filter wp_feed_cache_transient_lifetime before calling the fetch_feed and removed after we call end the fetching.

WE need to make also appropiate unit test to see that this is working ok.

https://secure.helpscout.net/conversation/541510231/157086/

@contactashish13 i would like your help in testing this new version using the next scenarios:

Use Case 1

• Download the latest production version from here: https://wordpress.org/plugins/feedzy-rss-feeds/
• Add a some feedzy widgets using different values for the fields
• Add some shortcodes using different attribute values
• Update the code to the new version from git https://github.com/Codeinwp/feedzy-rss-feeds/ the development branch
• Make sure the previously added widgets and shortcodes are working ok

Use case 2

• Download the development version from here https://github.com/Codeinwp/feedzy-rss-feeds-pro ( is the pro addon ) and use it with the development version from git of the lite one.
• make sure all the widgets/shortcodes are working ok.

Use case 3

• Make some widgets/shortcodes using both development versions of free and pro installed and make sure they are rendering properly

Please report any problem you find using enough details for us to replicate it

@selul It looks like our customers are a little bit bothered because we are continually asking for a review. I think we should ask only once. Or maybe once at three-six months.

https://wordpress.org/support/topic/constant-nagging/