Old function is in common.go. globalbeforecommand.go functions now ensure that the correct folder are present at runtime, and we do not want to implicitly modify the file system in other cases.

Verify that tenetCommand.Flags isn't accessed outside the package (and use addFlag/GetFlag as neccessary) and then make field private

talks about "removing"

Update defaultsConfig to have a docker section with an endpoint key, default value of unix:///var/run/docker.sock. Update the DockerClient function in util.go to read this config instead of a hardcoded value.

comment: "{{paramName}}" has the same name as its type.

^ Will produce an error.

comment: Parameter "{{paramName}}" has the same name as its type.

^ That does not error

daanikus hit a parse error: Failed run Flow function: failed to parse codelingo.yaml file `effective-go/codelingo.yaml`: yaml: line 11: did not find expected key yaml: line 11: did not find expected key /home/dev/projects/src/github.com/codelingo/platform/flow/bots/parse/parse.go:25: failed to parse codelingo.yaml file `effective-go/codelingo.yaml` /home/dev/projects/src/github.com/codelingo/platform/flow/flows/clair/query/query.go:136: /home/dev/projects/src/github.com/codelingo/platform/flow/flows/clair/query/query.go:52: /home/dev/projects/src/github.com/codelingo/platform/flow/flows/clair/clair.go:202: /home/dev/projects/src/github.com/codelingo/platform/flow/flows/clair/clair.go:56: /home/dev/projects/src/github.com/codelingo/platform/flow/server/server.go:263: /home/dev/projects/src/github.com/codelingo/platform/flow/server/server.go:157: Failed run Flow function /home/dev/projects/src/github.com/codelingo/platform/frontend/middleware/errors.go:108: daanikus hit a parse error

From @waigani on December 2, 2015 6:43

The documentation generated by lingo docs should include the directory that documentation pertains to.

Copied from original issue: lingo-reviews/tenets#7

In docker.go function Service, prompt the user for confirmation before calling Pull. The confirm code could be modelled on confirm.go:Confirm

All 32bit builds are failing and will not be useable by the end user.

# github.com/codelingo/codelingo/vendor/github.com/codelingo/clql/inner
../../../vendor/github.com/codelingo/clql/inner/inner_parser.go:1980: constant 4294967294 overflows int

In pullAll, if any single pull fails the entire process is aborted. Instead errors should be collected and returned at the end so as many tenets can be downloaded as possible.

From @lingo-reviews on December 9, 2015 19:23

Copied from original issue: lingo-reviews/tenets#21

cannot apply binary patch to 'flows/codelingo/docs/cmd' without full index line error

So, I don't exactly understand the "code" for this tenet, but it incorrectly marks functions as only returning nil all the time in our code. And these aren't edge cases, this is just normal go code. I'm not sure what's tripping it up.

"TypeError: Cannot access member x of undefined" error when calling a function directly under an exclude:

Example:

exclude:
  name as identName
  newConcat(identName, "test", funcName)

For the function:

- name: newConcat
    type: resolver
    body: |
      function (a, b) {   
        return a.concat(b)
      }

results in "TypeError: Cannot access member 'concat' of undefined"

Note funcName is defined elsewhere in query.

Remove the TODO comment in DesiredTenetCfgPath, the return actually is required in case the user makes an error during command execution (i.e. tries to use an undefined $VAR)

A function may have up to 3 field lists attached and, at this stage, there isn't a way to differentiate to ensure we're looking at the parameter list only.

lingo run docs --debug panics:

panic: close of nil channel

goroutine 20 [running]:
github.com/codelingo/codelingo/sdk/flow.(*flowRunner).setHelp.func1(0xb19280, 0xc4200be008, 0xac6e21, 0x3cb, 0xa4c000, 0x10edf60)
	/home/jesse/go/src/github.com/codelingo/codelingo/sdk/flow/cli.go:89 +0x1a7
github.com/codelingo/codelingo/vendor/github.com/urfave/cli.ShowAppHelp(0xc4200c91e0, 0xc4200be008, 0xaa70da)
	/home/jesse/go/src/github.com/codelingo/codelingo/vendor/github.com/urfave/cli/help.go:139 +0x189
github.com/codelingo/codelingo/vendor/github.com/urfave/cli.(*App).Run(0x10edf60, 0xc4200b2020, 0x2, 0x2, 0xb18600, 0xc42030eee0)
	/home/jesse/go/src/github.com/codelingo/codelingo/vendor/github.com/urfave/cli/app.go:214 +0x50b
github.com/codelingo/codelingo/sdk/flow.(*flowRunner).Run.func1(0xc420312c30)
	/home/jesse/go/src/github.com/codelingo/codelingo/sdk/flow/cli.go:127 +0x83
created by github.com/codelingo/codelingo/sdk/flow.(*flowRunner).Run
	/home/jesse/go/src/github.com/codelingo/codelingo/sdk/flow/cli.go:125 +0x3f

From @waigani on December 2, 2015 9:33

lingo cmd-does-not-exist
error: could not read configuration: stat /root/root/.lingo_home/.lingo: no such file or directory

Copied from original issue: lingo-reviews/tenets#8

The "lingo docs" command opens raw markdown, and at least on Linux, opens it in an editor (that's the behaviour of xdg-open). It would be nice if the markdown were rendered to HTML and opened in a browser.

RemoveCMD.BashComplete should not call util.BinTenets, instead try to read the config and call AllTenets and return the found tenet names

Stacked decorators should trigger one flow per decorator. For example, the Tenet below finds one func and comments on it once. I'd expect it to comment on the same func twice:

tenets:
  - name: find-funcs
    flows:
      codelingo/review:
        comment: This is a function, but you probably already knew that.
    query: |
      import codelingo/ast/go

      @ review "this is a custom comment"
      @ review comment
      go.func_decl(depth = any)

Reviewing with a binary tenet that has not been installed:

lingo review
The following errors were encounted:
The tenet "lingoreviews/juju_test_assert_loop_len" could not be found. Has it been installed?
The tenet "lingoreviews/juju_test_assert_loop_len" could not be found. Has it been installed?
The tenet "lingoreviews/juju_test_assert_loop_len" could not be found. Has it been installed?
.....

Just one message is enough.

From @waigani on December 2, 2015 10:12

lingo review
/main.go:3:13

    this comment could be more awesome


    ...

    package main

  > // comment a
    func a() {

    }

    ...

[o]pen: o
application (vi):
exec: "vi": executable file not found in $PATH
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0xb0 pc=0x56107e]

Copied from original issue: lingo-reviews/tenets#9

Any function, type or field that is public (i.e. starts with a capital letter) should have an associated comment documenting it. See this post for best practices.

https://circleci.com/gh/lingo-reviews/lingo/1

From @kat-co on December 9, 2015 19:53

One abstract example of how this might look is this:

Effectively, I'd just like something I can run non-interactively, but still human readable.

Copied from original issue: lingo-reviews/tenets#25

The comment above FormatPlainText has been resolved. Replace it with a comment documenting the function

lingo help review works, but lingo review --help does not show help. Instead a review is started.

From @waigani on December 1, 2015 7:27

You can see this in the json output of a review. It should be set to name of registered issue.

Copied from original issue: lingo-reviews/tenets#3

Create a new function OSOutf modelled on OSErrf - it will later be used to centralise cli output for logging, quiet mode etc.

From @lingo-reviews on December 9, 2015 19:36

Copied from original issue: lingo-reviews/tenets#23

From @kat-co on December 9, 2015 22:52

14:39> lingo ls
Incorrect Usage.

NAME:
list - list tenets

USAGE:
lingo list [options] [arguments...]

EXAMPLES:
Lists all tenets added to .lingo run.

OPTIONS:
--installed list all tenets installed on this machine

panic: flag provided but not defined: -color

goroutine 1 [running]:
main.main()
/home/jesse/go/src/github.com/lingo-reviews/lingo/main.go:22 +0x35b

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
/usr/lib/go/src/runtime/asm_amd64.s:1696 +0x1

goroutine 20 [syscall]:
os/signal.loop()
/usr/lib/go/src/os/signal/signal_unix.go:22 +0x18
created by os/signal.init.1
/usr/lib/go/src/os/signal/signal_unix.go:28 +0x37

Copied from original issue: lingo-reviews/tenets#31

If buildTenet returns some errs, set a bool that changes the message used by FinishPrint

If all the go files are nested inside dirs and none are at the same level as the codelingo.yaml then the nested go files will be ignored.

The "--alll" flag is not defined. Showing the help is correct, but not the panic.

$ lingo ls --all
Incorrect Usage.

NAME:
   list - list tenets

USAGE:
   lingo list [options] [arguments...]

EXAMPLES:
   Lists all tenets added to .lingo run.

OPTIONS:
   --installed  list all tenets installed on this machine

panic: flag provided but not defined: -all

goroutine 1 [running]:
main.main()
    /home/jesse/go/src/github.com/lingo-reviews/lingo/main.go:22 +0x35b

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
    /usr/lib/go/src/runtime/asm_amd64.s:1696 +0x1

goroutine 34 [syscall]:
os/signal.loop()
    /usr/lib/go/src/os/signal/signal_unix.go:22 +0x18
created by os/signal.init.1
    /usr/lib/go/src/os/signal/signal_unix.go:28 +0x37

In toml definitions of data structures (i.e. type Config) use 'omitempty' tags to prevent empty keys being written to the file (as empty and missing keys will be read back the same). See https://golang.org/pkg/encoding/json/ for example usage

From @guycook on December 14, 2015 4:2

Copied from original issue: lingo-reviews/tenets#33

A few times we prompt for editor (or assume vim), it would be good to see if $EDITOR is set and use that first

From @kat-co on December 9, 2015 19:57

Please let me know what information you need about my environment to help triage.

• Google Chrome from standard deb.
• Ubuntu 15.10

Copied from original issue: lingo-reviews/tenets#26

It would be great to have a place to go look at the progress of the running tenets, and stop/restart them. But I'd settle for it not just running forever.

Actually... is there a way to stop a running check on github? I don't see any UI for it.

https://github.com/codelingo/codelingo/pull/183/files/45cd9fa11c370e12d1268ea2064f77729feb1b6f#diff-4572ade8a10fa27a4592455f0cdc234a

We'd like the tenet to exclude named imports if there is a naming conflict, but the tenet will compare each import to all other imports. This results in false positives.

This is no longer used and has been replaced by util.LingoHome

rewrite currently doesn't support rewriting of filenames.

go.file(depth = any):
filename as fname

    @rewrite --replace name
    filename

From @lingo-reviews on December 15, 2015 19:4

From James Tunnicliffe:

When I try and log into http://www.lingo.reviews/ through Github I get
a blank pop-up with an URL starting
http://lingo.reviews/_oauth/github. Looking at the console it has the
error "Uncaught SecurityError: Blocked a frame with origin
"http://lingo.reviews" from accessing a frame with origin
"http://www.lingo.reviews". Protocols, domains, and ports must match."
I tried deleting the authorisation on Github and re-authing, but get
the same error. The URL that Github redirects to is
http://lingo.reviews/_oauth/github?close=&code=. If
I visit lingo.reviews without the www. I get redirected. So, it looks
like a minor configuration issue - stop redirecting to www.

Copied from original issue: lingo-reviews/tenets#35

This appears to be because OS X doesn't allow a net.ListenUnix call with a unix address with no Name.

Changing these to use a :0 bound TCP Listener appears to make them run properly, and accept the source.

I'm willing to work on a PR against this and the tenets repo to fix this, if there's interest.

package main

import (
	"fmt"
)

type Thing struct {
    name       string
    generation int
    model      string
}

func main() {
  thing = Thing{name: “Raspberry Pi”, generation: 2, model: “B”}
}

Generating queries from the above code takes user to blank page. Error in console is:

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined.

Didn't see any output on slack errors channel.

My workaround is to use a notEquals func as I can't currently do
name != bname