codesequence / ngrx-workshop-ngconf2020 Goto Github PK

On p. 143 of NgRxWorkshop.pdf, a comma needs to be inserted immediately after "group" in the 1st bullet point:

Using sticky notes, as a group identify all of the events in the system

WRT the following code on p. 167 of NgRxWorkshop.pdf:

export const moviesReducer = createReducer(
  initialState,
  on(MoviesPageActions.enter, (state, action) => {
    return {
      ...state,
      activeMovieId: null
    };
  }),
  on(MoviesPageActions.clearSelectedMovie, (state, action) => {
    return {
      ...state,
      activeMovieId: null
    };
  }
));

The return code is identical in both on() functions:

    return {
      ...state,
      activeMovieId: null
    };

I recommend extracting that code to a method to adhere to the D.R.Y. principle.

"Community-driven" (cf. https://en.wikipedia.org/wiki/Compound_modifier).

On p. 120 of NgRxWorkshop.pdf, "triggers" needs to be replaced with the "trigger" in the 2nd bullet point on that (RESPONSIBILITIES) page

Effects triggers side effects

from pp. 16-19 (cf. https://en.wikipedia.org/wiki/Compound_modifier)

Hi,

In the Challenge on p. 83 of NgRxWorkshop.pdf, I read the following:

1. Open books-page.actions.ts

At 7aee78a, however, you have us modify books-api.actions.ts, not books-page.actions.ts.

I believe (but wanted to check with you) that (whether) both files should read (be) the same.

I believe the correct fix is to replace "books-page.actions.ts" with "books-api.actions.ts" on p. 83 of NgRxWorkshop.pdf.

WRT the following line in books-page.actions.ts:

export const enter = createAction("[Books Page] Enter");

Just a thought; I'm thinking that it would be more consistent to name it "enterBook" since the other functions include "Book" at the end of their name (selectBook, clearSelectedBook, createBook, updateBook and deleteBook).

No issue, guys, sorry.

Not sure what I was looking at but the code at time point 24:42 for Day 2 is just fine. Could have sworn the code for updateBook in the on() method was quite different.

This is great hands-on and really clears up any questions a student might have learning NgRx. Well worth the price of admission, guys. Nice job.

(cf. https://en.wikipedia.org/wiki/Compound_modifier)

... in the following sentence:

NgRx prescribes an architecture for managing the state and side effects in you Angular application.

While working on the first exercise, it occurred to me that -- although I know we're creating a record under the covers -- it might be a little more user-friendly to display "Add Book" in lieu of "Create Book" in the following line of book-detail.component.html:

<ng-template #prompt>Create Book</ng-template>

(Not sure if this would necessitate replacing other occurrences of "Create"/"create" with "Add"/"add" throughout the code.)

Hi, Mike.

Just before 01:29:18 of Day 1 of the Learn NgRx from the creators of NgRx Workshop, you mentioned to Brandon that the last bullet point needs to be removed.

In response, here's a reminder to remove the last bullet point from page 131 of NgRxWorkshop.pdf, viz.:

Strongly typed using classes and enums

(BTW, it appears that this was already done on p. 324 of NgRxWorkshop.pdf.)