codidact / donations Goto Github PK

If a logged-in user starts a donation but doesn't complete it, we (once) send email about it. The email is well-written and not naggy, but it does assume that the incomplete transaction was the user's doing. ​I think we intended it for the case where the user might have meant to complete the transaction and maybe even thought it was complete (missed a final click).

We recently had some problems with Stripe, so users trying to make donations got error messages. Then they got email asking about the incomplete transaction. Beyond Stripe errors, we could theoretically have some other server error, like the API call failing or timing out or something. Can we not send the email if the attempted donation produced an error?

I really hope this is a rare occurrence, but it's also something that can aggravate the affected people. Can we add this check to our send-email logic?

The donations server fails with "Internal Server Error" if there is an entry in the donations table. I've tried a bunch of permutations, including amounts with and without currency symbols. I can't find a way to enter data that doeesn't cause a failure.

Here's an example from the admin console:

Public name: Another test
Message: Keep up the good work :-)
Date: 2022-01-01
Amount: $5.00
Link: (a valid link to a Stripe transaction)

When I deleted that entry, the page worked again (with no data, of course):

I then created a simpler entry: name, message, date, amount, but no link. Failed.
I removed the amount: failed.
Then the message: failed.
Then the date (so there is now only a name): failed.
Removed even the name: failed.

Removed the now-empty entry: worked again.

This is a blocker for publicly thanking our donors.