codybartfast / knr Goto Github PK

Since these values are being compared directly to 0 it might be a good idea to make it explicit like this enum { OK=0, ERROR };.
There is also stdbool.h which defines true and false if that appeals.

Originally posted by @klampworks in #2

Maybe consider have one pointer and then making the other variables int offsets instead.
I think it will make this function much simpler.

Originally posted by @klampworks in #2

Do these need to be **? You can use & to get the address of a variable at any time, you don't necessarily need use the maximum number of stars in the declaration.

Originally posted by @klampworks in #2

I think parsearguments would be a better name to explain what this function does.

Originally posted by @pbruyninckx in #2

Definately going to have to think about/play with that one.

Originally posted by @codybartfast in #2

Just read through your solution for this one, it's an elegant and simple solution to a complex problem. Kudos dude! 🥇

Is this used? Consider adding static to functions you only intend to use in this C file so the compiler can tell you it's unused.

Originally posted by @klampworks in #2

What would happen if these mallocs fail?

Originally posted by @klampworks in #2