cognitedata / 3d-web-parser Goto Github PK

Several of our models in production have nodes without color. @dragly fixed this by assigning them a color, but this makes i.e. Ivar Aasen look funny:

We should set gray as default color or figure out why the previous version of the viewer colors it gray.

As @Verkhovskaya mentioned, the way the different groups are created now is way more code than is requred. Instead of having setColor(color: THREE.Color) etc, we can have generic
set(type, value) and each group defines a list of types (the parent class PrimitiveGroup will start the list by having

this.types = {
  nodeId: new Float64Array(this.count);
  treeIndex: new Float32Array(this.count);
  color: new Float32Array(3 * this.count);
}

whereas the CircleGroup will have in its constructor
this.types['normal'] = new Float32Array(3 * this.count)

or something.

It would seem that neither of these need to be async. If this is fixed, the await statements in the viewer would need to be removed too.

After a group is full / a new one is created, we may want to resize the current group so its capacity is exactly its count to minimize memory usage. This will require some extra copying which hopefully isn't much slower.