coin3d / dime Goto Github PK

Original report by Bernd Waibel (Bitbucket: waebbl, GitHub: waebbl).

In the root CMakeLists.txt file at line 271, there's an if clause

#!cmake

if(COIN_BUILD_SHARED_LIBS)

see https://bitbucket.org/Coin3D/dime/src/47290a4eb762478b2e71ddf6f88f2fce21bfde45/CMakeLists.txt#lines-271

Shouldn't this read

#!cmake
if(DIME_BUILD_SHARED_LIBS)

?

from line 69 on LWPolyline.cpp

dimeLWPolyline::~dimeLWPolyline()
{
}

I seem it should be like this:

dimeLWPolyline::~dimeLWPolyline()
{
	delete[] this->xcoord;
	delete[] this->ycoord;
	delete[] this->startingWidth;
	delete[] this->endWidth;
	delete[] this->bulge;
}

Thirteen years ago, I saw a commit that changed the open source license from GPL to BSD. What was the reason for this?