coinid / coinidwallet Goto Github PK
View Code? Open in Web Editor NEWBitcoin storage solution that supports offline storage without the need to purchase specialized hardware
License: MIT License
coinidwallet's People
Contributors
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
![gitlocalize-app[bot] avatar](https://avatars.githubusercontent.com/in/40992?v=4 "gitlocalize-app[bot]")
Stargazers
Watchers
coinidwallet's Issues
Myriadcoin URI for qr codes
COINid uses myriad, the correct URI for Myriadcoin qr codes is myriadcoin.
Move devDependencies that required to compile the app to dependencies [PATCH included]
When NODE_ENV="production" environment variable is used, app compilation fails cause some dependencies required to compile the app are in devDependencies instead of dependencies in package.json file.
- rn-nodeify
Line 92 in c557790
which is used in postinstall:
Line 8 in c557790
without ityarn installcommand fail with
$ node node_modules/rn-nodeify/cmd.js --install stream,buffer,events,assert,crypto,vm --hack
internal/modules/cjs/loader.js:883
throw err;
^
Error: Cannot find module '/home/appuser/app/wallet/COINiDWallet-1.8.0/node_modules/rn-nodeify/cmd.js'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
error Command failed with exit code 1.
- metro-react-native-babel-preset
Line 85 in c557790
without it./gradlew assembleReleasefail with:
> Task :app:bundleReleaseJsAndAssets
error index.js: Cannot find module 'metro-react-native-babel-preset' from '/home/appuser/app/wallet/COINiDWallet-1.8.0'
- node-mock-server
Line 88 in c557790
without it./gradlew assembleReleasefail with:
> Task :app:bundleReleaseJsAndAssets
error Unable to resolve module `node-mock-server/react-native/utils` from `/home/appuser/app/wallet/COINiDWallet-1.8.0/src/utils/feeHelper.js`: Module `node-mock-server/react-native/utils` does not exist in the Haste module map
To fix apply patch like to package.json file:
@@ -65,6 +65,9 @@
"set-value": "^2.0.1",
"socket.io-client": "^2.2.0",
"stream-browserify": "^1.0.0",
+ "metro-react-native-babel-preset": "^0.66.0",
+ "node-mock-server": "https://github.com/COINiD/node-mock-server.git",
+ "rn-nodeify": "^10.3.0",
"vm-browserify": "0.0.4"
},
"devDependencies": {
@@ -82,14 +85,11 @@
"eslint-plugin-react": "^7.12.4",
"jest": "^24.5.0",
"jest-fetch-mock": "^2.1.0",
- "metro-react-native-babel-preset": "^0.53.1",
"mock-async-storage": "^2.0.4",
"mock-socket": "^8.0.5",
- "node-mock-server": "https://github.com/COINiD/node-mock-server.git",
"react-dom": "^16.7.0",
"react-native-version": "^2.7.0",
- "react-test-renderer": "16.8.3",
- "rn-nodeify": "^10.0.0"
+ "react-test-renderer": "16.8.3"
},
"jest": {
"preset": "react-native",Add .ipa file to github releases
Add .ipa file (ios app) to the github releases as asset:
https://github.com/COINiD/COINiDWallet/releases
[Android] Submit App to F-Droid
F-Droid URL: https://f-droid.org/
F-Droid Wikipedia: https://www.wikipedia.org/wiki/F-Droid
Contribution/Submit Applications: https://f-droid.org/en/contribute/#submit-applications
Inclusion Policy: https://f-droid.org/en/docs/Inclusion_Policy
Request For Packaging Tickets: https://gitlab.com/fdroid/rfp/issues
F-Droid is application & app store for android apps (alternative to Google Play) that accepts only FLOSS (free/libre and open-source) apps and doesn't require any account creation/login in order to download apps.
The requirements for being included into f-droid are here: https://f-droid.org/en/docs/Inclusion_Policy/
The process for getting an app published to f-droid is outlined here: https://f-droid.org/en/docs/Inclusion_How-To/ https://gitlab.com/fdroid/rfp#submission-queue https://gitlab.com/fdroid/fdroiddata/blob/master/CONTRIBUTING.md
You can open a RFP (Request For Packaging) ticket here: https://gitlab.com/fdroid/rfp or an user can do so, provided you agree to include this app in F-droid (a comment to this issue is enough for it)
Some users don't have play-store on their devices as they are degoogled devices or don't create/use google account (using aurora store app https://auroraoss.com/ in anonymous mode (which is available on f-droid) is solution to still get apps from google-play) or using OS/custom ROMs that don't have it included, such as: (Some bundle f-droid by default)
https://grapheneos.org/ GrapheneOS
https://calyxos.org/ CalyxOS
https://lineageos.org/ LineageOS
https://lineage.microg.org/ LineageOS for microG
https://e.foundation/ /e/
https://www.replicant.us/ Replicant
Downloading APKs from official places like github releases https://github.com/COINiD/COINiDWallet/releases or website, or from unofficial sources like APK downloading sites https://apk.support or https://apkpure.com/ etc... will avoid the play-store/google dependency but it's lack automatic update mechanism unless it's built in into the application, F-Droid solve this.
Once the app is published into f-droid add the below image code into
README.md to show that the app available on f-droid:
[<img src="https://fdroid.gitlab.io/artwork/badge/get-it-on.png" alt="Get it on F-Droid" height="80">](https://f-droid.org/en/packages/org.fdroid.fdroid/)
Please provide verifiable builds
Your FAQ claims
Do you provide deterministic builds? Since we need to distribute the app via the App Store that is not possible. The source is however available on our Github so that anyone can review and compile it.
Could you please elaborate?
Verifiable builds are maybe a bit a lower standard than fully deterministic builds in the sense that the signature also has to be reproducible but for what it's worth, due to the lack of documentation I also failed to compile the app at all. Maybe you can help me out. Here are my detailed findings.
Add instructions for adding ./config/build file
Building the app result in error that ./config/build file is missing, it needs to be created like the secrets.js file that has explanation here:
https://github.com/COINiD/COINiDWallet#secretsjs
error Unable to resolve module `../config/build` from `/app/coinid/src/settingstree/About.js`: The module `../config/build` could not be found from `/app/coinid/src/settingstree/About.js`. Indeed, none of these files exist:
* `/app/coinid/src/config/build(.native||.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)`
* `/app/coinid/src/config/build/index(.native||.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)`
it need the params:
commit
tag
dirty
time
version
PNGs not generated in deterministic way
Building latest android version and compare it to apk from google play result in many diffs in .png files below, probably cause build process optimize the PNG, which should be avoided, see disabling cruncherEnabled at: https://f-droid.org/en/docs/Reproducible_Builds/#png-crushcrunch or maybe need other setting like vectorDrawables.useSupportLibrary = true, etc..
Files ./gp/res/drawable/gradient.png and ./coindwallet_rebuild/res/drawable/gradient.png differ
Files ./gp/res/drawable-hdpi-v4/ic_launcher_background.png and ./coindwallet_rebuild/res/drawable-hdpi-v4/ic_launcher_background.png differ
Files ./gp/res/drawable-ldpi-v4/ic_launcher_background.png and ./coindwallet_rebuild/res/drawable-ldpi-v4/ic_launcher_background.png differ
Files ./gp/res/drawable-mdpi-v4/ic_launcher_background.png and ./coindwallet_rebuild/res/drawable-mdpi-v4/ic_launcher_background.png differ
Files ./gp/res/drawable-xhdpi-v4/ic_launcher_background.png and ./coindwallet_rebuild/res/drawable-xhdpi-v4/ic_launcher_background.png differ
Files ./gp/res/drawable-xxhdpi-v4/ic_launcher_background.png and ./coindwallet_rebuild/res/drawable-xxhdpi-v4/ic_launcher_background.png differ
Files ./gp/res/drawable-xxxhdpi-v4/ic_launcher_background.png and ./coindwallet_rebuild/res/drawable-xxxhdpi-v4/ic_launcher_background.png differ
Files ./gp/res/mipmap-hdpi-v4/ic_launcher.png and ./coindwallet_rebuild/res/mipmap-hdpi-v4/ic_launcher.png differ
Files ./gp/res/mipmap-hdpi-v4/ic_launcher_round.png and ./coindwallet_rebuild/res/mipmap-hdpi-v4/ic_launcher_round.png differ
Files ./gp/res/mipmap-hdpi-v4/logo.png and ./coindwallet_rebuild/res/mipmap-hdpi-v4/logo.png differ
Files ./gp/res/mipmap-mdpi-v4/ic_launcher.png and ./coindwallet_rebuild/res/mipmap-mdpi-v4/ic_launcher.png differ
Files ./gp/res/mipmap-mdpi-v4/ic_launcher_round.png and ./coindwallet_rebuild/res/mipmap-mdpi-v4/ic_launcher_round.png differ
Files ./gp/res/mipmap-mdpi-v4/logo.png and ./coindwallet_rebuild/res/mipmap-mdpi-v4/logo.png differ
Files ./gp/res/mipmap-xhdpi-v4/ic_launcher.png and ./coindwallet_rebuild/res/mipmap-xhdpi-v4/ic_launcher.png differ
Files ./gp/res/mipmap-xhdpi-v4/ic_launcher_round.png and ./coindwallet_rebuild/res/mipmap-xhdpi-v4/ic_launcher_round.png differ
Files ./gp/res/mipmap-xhdpi-v4/logo.png and ./coindwallet_rebuild/res/mipmap-xhdpi-v4/logo.png differ
Files ./gp/res/mipmap-xxhdpi-v4/ic_launcher.png and ./coindwallet_rebuild/res/mipmap-xxhdpi-v4/ic_launcher.png differ
Files ./gp/res/mipmap-xxhdpi-v4/ic_launcher_round.png and ./coindwallet_rebuild/res/mipmap-xxhdpi-v4/ic_launcher_round.png differ
Files ./gp/res/mipmap-xxhdpi-v4/logo.png and ./coindwallet_rebuild/res/mipmap-xxhdpi-v4/logo.png differ
Files ./gp/res/mipmap-xxxhdpi-v4/ic_launcher.png and ./coindwallet_rebuild/res/mipmap-xxxhdpi-v4/ic_launcher.png differ
Files ./gp/res/mipmap-xxxhdpi-v4/ic_launcher_round.png and ./coindwallet_rebuild/res/mipmap-xxxhdpi-v4/ic_launcher_round.png differ
Files ./gp/res/mipmap-xxxhdpi-v4/logo.png and ./coindwallet_rebuild/res/mipmap-xxxhdpi-v4/logo.png differ
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.