colin-aarts / irc-js-bot Goto Github PK

Line 196 of node_modules/irc-js-bot-admin/index.coffee should probably say (changes in bold):

"I successfully deleted the factoid « #{factoid_name} » and all aliases leading to it. The deleted factoid's content was « #{factoid_content} »"

The code has a check for this, but the generated JavaScript doesn't do what you expect. Also as proof, the currently running rivvles if you do "`del foo" will respond that it deleted the factoid "foo" with the value "undefined".

The code as it stands:

not input_data.args.trim() of @factoids

which is translated to:

!input_data.args.trim() in _this.factoids

is the same as:

(!input_data.args.trim()) in _this.factoids

but what you really want is:

!(input_data.args.trim() in _this.factoids)

not (input_data.args.trim() of @factoids)

Line 119 in node_modules/irc-js-bot-admin/index.coffee

RegExp throws an error if value fed to it is an invalid regex, this exception is not caught and causes the bot's connection to reset (after which it rejoins shortly).

Ex:

try {
    new RegExp("[");
} catch(e) {
    console.log(e);
}

The bot does recover/rejoin, but it might be nicer to display a response to the user indicating the regex was bad.

It would seem that admin-only commands can be used by non-admins. I'm certainly not an admin, and I can create and delete factoids! This can be verified by doing stuff like "set foo = bar" "del foo" in private message to an instance of the bot.