Comments (9)
Thanks for the issue writeup.
This is really a swift 4.0 -> 4.1 issue, but it was forced by the Xcode 9.3 update.
We're generally committed to supporting the latest non-beta releases of Xcode and Swift. So, we can't just switch back to flatMap as that means we would not compile for Swift 4.1.
We could either:
-
Change the README to indicate we only support Xcode 9.3. This probably doesn't really help you, but at least we'd be more accurate in our description.
-
Add a "preprocessor" check to use
compactMap
for 4.1 andflatMap
for 4.0. I think this would look like#if swift(>=4.1)
but that's just off the top of my head. If you wanted to submit that as PR that would be fine with us.
Hope this helps.
from mamba.
@dcoufal
If you accept the PR how long would you expect a new release to be made?
from mamba.
I'd guess within a day. if that doesn't happen, ping us/me in this ticket.
Also, you'll have to agree to the Comcast CLA before we could merge. I'm showing that you have not signed. Let me know if you have technical problems with that.
from mamba.
I did submit my agreement but it seems to not update. Getting a message saying it might be my email but I verified my email used for the commit is under my profile.
from mamba.
Yeah, I'm not sure either. I will check with our open source GitHub admins and get back to you.
from mamba.
Seems it was just updated. CLA signed.
from mamba.
Fixed and merged.
from mamba.
@jgainfort mamba 1.0.5 is released. Cocoapods takes a little time if that's what you're using.
from mamba.
@dcoufal Thank you!
from mamba.
Related Issues (20)
- Enable module stability. Now can't use with Swift 5.3.2. HOT 5
- Swift Compiler Code Optimization
- Add Swift Package Manager Support HOT 1
- Tag new release 1.5.6 HOT 6
- Remove `HLS` prefix from all classes HOT 1
- Should be an interface to figure out the muxed/demuxed makeup of an asset HOT 1
- The `playlistType` for a variant playlist should be cached and not calculated every time. HOT 1
- Add a simple function to return segment based info from info about a tag to look for. HOT 1
- Remove the HLSTagCriteria and HLSTagCriterion Query Language objects HOT 1
- v 1.2.0 cocoapods HOT 12
- Add more owners to podspec
- Carthage Build Error HOT 9
- Revert deployment changes made in #61 HOT 2
- Using .transform and replacing a tag of tagDescription PantosTag.Location results in a invalid playlist with literal #Location HOT 3
- How could I add it in my project ? HOT 1
- LHLS Support - Low-Latency HLS HOT 1
- improve (HLS)ValidationIssue HOT 2
- Swift Package Manager support? HOT 1
- Parsing malformed HLS causes crash
- Updating podspec to include fix for static libraries HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mamba.