Giter VIP home page Giter VIP logo

Comments (9)

dcoufal avatar dcoufal commented on May 27, 2024

Thanks for the issue writeup.

This is really a swift 4.0 -> 4.1 issue, but it was forced by the Xcode 9.3 update.

We're generally committed to supporting the latest non-beta releases of Xcode and Swift. So, we can't just switch back to flatMap as that means we would not compile for Swift 4.1.

We could either:

  • Change the README to indicate we only support Xcode 9.3. This probably doesn't really help you, but at least we'd be more accurate in our description.

  • Add a "preprocessor" check to use compactMap for 4.1 and flatMap for 4.0. I think this would look like #if swift(>=4.1) but that's just off the top of my head. If you wanted to submit that as PR that would be fine with us.

Hope this helps.

from mamba.

jgainfort avatar jgainfort commented on May 27, 2024

@dcoufal
If you accept the PR how long would you expect a new release to be made?

#24

from mamba.

dcoufal avatar dcoufal commented on May 27, 2024

I'd guess within a day. if that doesn't happen, ping us/me in this ticket.

Also, you'll have to agree to the Comcast CLA before we could merge. I'm showing that you have not signed. Let me know if you have technical problems with that.

from mamba.

jgainfort avatar jgainfort commented on May 27, 2024

I did submit my agreement but it seems to not update. Getting a message saying it might be my email but I verified my email used for the commit is under my profile.

from mamba.

dcoufal avatar dcoufal commented on May 27, 2024

Yeah, I'm not sure either. I will check with our open source GitHub admins and get back to you.

from mamba.

jgainfort avatar jgainfort commented on May 27, 2024

Seems it was just updated. CLA signed.

from mamba.

dcoufal avatar dcoufal commented on May 27, 2024

Fixed and merged.

from mamba.

dcoufal avatar dcoufal commented on May 27, 2024

@jgainfort mamba 1.0.5 is released. Cocoapods takes a little time if that's what you're using.

from mamba.

jgainfort avatar jgainfort commented on May 27, 2024

@dcoufal Thank you!

from mamba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.