comit-network / monero-rs Goto Github PK

a4abc80

Do the multiplication inside the make_bulletproof and verify_bulletproof functions so that things are consistent on the inner and outer layer and we can just pass the commitments into the transaction.

Mostly pass-through functions but PrivateKey doesn't offer arithmetic.

1. Use conquer_once instead of lazy_static macro
2. Explore what it would take to compute it inside a const

Currently tested as part of the big integration test for monero-adaptor. Needs unit tests in here though.

We need to use a particular Monero hash function as part of creating all the BulletproofGens. Our current implementation in comit-network/hash_edwards_to_edwards vendors slightly modified code from Monero's codebase. We would like to implement this in Rust.

To make adapter signatures possible, we need access to internal state of the signing algorithm. See 2fe0280 (#28).

Instead of returning this one constant from the signing function, we should re-model the loop inside the algorithm to a type-level state machine that makes execution of the algorithm safe and gives read-only access to internal state like this constant so that other protocols can be built on top of it safely.

Brings virtually no benefit and has an unnecessary dependency footprint with primitive_types.

i.e. Clsag::c1 should be a Scalar etc