Giter VIP home page Giter VIP logo

fshelpers's People

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar

Forkers

toburger marneedear projecteon

fshelpers's Issues

Are the ArmHelper authenticate functions mixed up?

I think the function names and descriptions are mixed up for authenticate and authenticateDevice.

Source code here
https://github.com/CompositionalIT/fshelpers/blob/master/src/FsHelpers/ArmHelper/ArmHelper.fs#L110

authenticate can run unattended by passing in the tenant Id and a client secret.

authenticateDevice needs human interaction to complete the authentication process.

But the descriptions indicate the opposite.

I think the function names and descriptions should be swapped, but maybe I'm not understanding it?

If this is changed it will affect the SAFE-Template and SAFE docs, too.

(Thanks for this helper! I have been struggling to get automated deployments to Azure working and the SAFE documentation and these helpers have made my life much easier.)

Fix build warnings in ArmHelper

Seen now in FAKE 5:

C:\Users\Isaac\Source\Repos\safe-azure\paket-files/build/CompositionalIT/fshelpers/src/FsHelpers/ArmHelper/ArmHelper.fs (17,9)-(17,22): Warning FS1178: The struct, record or union type 'ParameterType' is not structurally comparable because the type 'obj' does not satisfy the 'comparison' constraint. Consider adding the 'NoComparison' attribute to the type 'ParameterType' to clarify that the type is not comparable
C:\Users\Isaac\Source\Repos\safe-azure\paket-files/build/CompositionalIT/fshelpers/src/FsHelpers/ArmHelper/ArmHelper.fs (31,5)-(31,22): Warning FS1178: The struct, record or union type 'ResourceGroupType' is not structurally comparable because the type 'Core.Region' does not satisfy the 'comparison' constraint. Consider adding the 'NoComparison' attribute to the type 'ResourceGroupType' to clarify that the type is not comparable
C:\Users\Isaac\Source\Repos\safe-azure\paket-files/build/CompositionalIT/fshelpers/src/FsHelpers/ArmHelper/ArmHelper.fs (33,5)-(33,15): Warning FS1178: The struct, record or union type 'Deployment' is not structurally comparable because the type 'ResourceGroupType' does not satisfy the 'comparison' constraint. Consider adding the 'NoComparison' attribute to the type 'Deployment' to clarify that the type is not comparable
C:\Users\Isaac\Source\Repos\safe-azure\paket-files/build/CompositionalIT/fshelpers/src/FsHelpers/ArmHelper/ArmHelper.fs (39,5)-(39,25): Warning FS1178: The struct, record or union type 'AuthenticatedContext' is not structurally comparable because the type
'IResourceManager' does not satisfy the 'comparison' constraint. Consider adding the 'NoComparison' attribute to the type 'AuthenticatedContext' to clarify that the type is not comparable
C:\Users\Isaac\Source\Repos\safe-azure\build.fsx (111,69)-(111,94): Warning FS0052: The value has been copied to ensure the original is not mutated by this operation or because the copy is implicit when returning a struct from a member and another member is then accessed

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.