[L06] Potential function clashes about comet HOT 3 CLOSED

Great point @cylon56. We decided to use slither-check-upgradeability plugin of slither library to check for clashes of functions between TransparentUpgradeableConfiguratorProxy and Configurator. So basically moving this problem off-chain via an additional static code analysis check.

from comet.

We analyzed the cases where a clash can occur and found that these cases are non-critical and recoverable.

The two types of clashes that can happen are:

• New function on proxy is introduced that clashes with an existing function in the Configurator. Admin is no longer able to call the function on the Configurator.
  • To recover: The admin should still be able to upgrade the implementation of the proxy because that function lives on the proxy. Governance can simply introduce a new version of Configurator without the clash and upgrade the proxy to this new implementation.
• New function on Configurator is introduced that clashes with an existing function on the proxy. Admin cannot call this new Configurator function.
  • To recover: Same recovery path as above. Function clashes only prevent the admin from calling a function on the Configurator, so the admin is still able to call the upgrade function on the proxy itself.

In either case, the contracts are in a recoverable state and nothing malicious can happen unless the admin is malicious.

We are also exploring a slither-check-upgradeability plugin of slither library to check for clashes of functions between ConfiguratorProxy and Configurator (#430).

from comet.

We added the slither check in addition to the above guidance/remedies, closing.

from comet.