[M01] `governor` can approve anyone to transfer the base and collateral assets within the Comet contract about comet HOT 4 CLOSED

I think that we should always disclose known risks in the documentation if we are aware of them. If we decide to add extra defenses we should document that as well. I'd say a good spot is in the docs in the governance section for approveThis https://github.com/compound-finance/comet/tree/main/docs#erc-20-approve-manager-address

from comet.

Added note to the docs here #414

from comet.

The main intention for having approveThis is to allow governance to transfer out any ERC20s accidentally sent to Comet. We do recognize the ability for governance to give approval for the base and collateral assets and transfer out user funds.

However, as you noted, this will likely require a governance attack. We'd like to point out that in the case of a governance attack, the attacker would not even need approveThis to steal user funds as they could upgrade the implementation of Comet to whatever they please.

@ajb413 Do you think this governance attack risk is worth documenting, and if so, where would be the best spot to detail this risk?

from comet.

Sounds good, thanks Adam!

from comet.