controller questions about concerto-hardware HOT 2 CLOSED

screen_api is used here and in the frontend in core concerto - it is required when you want a view to be accessible using Screen authorization (a private token as specified). Without it, CanCan ability checks and current_accessor checks will return nil if no user is logged in, regardless of whether a screen is logged in. With it, these use the current screen if one is logged in, and the current user otherwise (or nil if neither). I can't think off the top of my head of any other plugins that would need to use it, it's really just for actions that provide an endpoint for screens to talk (here it's because Bandshell logs in to Concerto as a "Screen" to access it's Player properties. In Frontend::ScreensController, it's to allow authenticated browsers to access the screen frontend).

I'll leave this open for now, I'm not quite sure whether the require_dependency is doing something useful or is some old leftover.

from concerto-hardware.

Closing this out because it seems require_dependency is not needed if we specify ConcertoHardware::ApplicationController as the parent class. Another option might be to autoload it in the module, but this way is nice and explicit (conversely, less magical).

I tested the latest commit (88bf84e) in production and in development, including when a reload occurs in development, and it looks good. Any problems can be a new ticket.

from concerto-hardware.