Giter VIP home page Giter VIP logo

sprucecss-root-admin-template's People

Contributors

adamlaki avatar szepeviktor avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar

sprucecss-root-admin-template's Issues

Eleventy plugin to change file name based on hash of its content

Current global random hash
/js/repeater.js?ddbd3ad9-530c-44b3-bef8-58a921959a1a
👇🏻 hash of the file's content
/js/repeater.js?e7fd847f7f435b18e64192d282f82c75
👇🏻 include the hash in the file name, query parameters are error prone
/js/repeater.e7fd847f7f435b18e64192d282f82c75.js

Where is that plugin??

  • Hashes can be shorter.
  • Only the URL of changed files would update.

search.class is never set

sprucecss-root-admin-template/src/_includes/partial/search.html

Line 1 in faac557

<form class="search-form {{ search.class }}">

Comes from dataTable.searchClass

It is always null.

$ grep -r 'form class="search-form'
dist/products/index.html:                                <form class="search-form ">
dist/customers/index.html:                                <form class="search-form ">
dist/orders/index.html:                                <form class="search-form ">
src/_includes/partial/search.html:<form class="search-form {{ search.class }}">

Is it null by mistake?

Deep inspection of HTML

Hello!
There is a tool called html-validate.
https://gitlab.com/html-validate/html-validate/-/blob/master/README.md

It is extremely simple to use.

yarn add html-validate
yarn run html-validate index.html

Current output for the sign-up page

   14:58   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   16:77   error  Expected omitted end tag <link> instead of self-closing element <link/>    void-style
   17:54   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   18:76   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   19:87   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   20:48   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   21:82   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   22:61   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   23:96   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   24:97   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   25:91   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   26:92   error  Expected omitted end tag <meta> instead of self-closing element <meta/>    void-style
   27:67   error  Expected omitted end tag <link> instead of self-closing element <link/>    void-style
   37:26   error  Attribute "width" used ' instead of expected "                             attr-quotes
   37:37   error  Attribute "height" used ' instead of expected "                            attr-quotes
   37:49   error  Attribute "viewBox" used ' instead of expected "                           attr-quotes
   37:70   error  Attribute "version" used ' instead of expected "                           attr-quotes
   37:84   error  Attribute "xmlns" used ' instead of expected "                             attr-quotes
   37:119  error  Attribute "xmlns:xlink" used ' instead of expected "                       attr-quotes
   37:162  error  Attribute "xml:space" used ' instead of expected "                         attr-quotes
   37:183  error  Attribute "xmlns:serif" used ' instead of expected "                       attr-quotes
   37:219  error  Attribute "style" used ' instead of expected "                             attr-quotes
   37:219  error  Inline style is not allowed                                                no-inline-style
   37:306  error  Attribute "class" used ' instead of expected "                             attr-quotes
  102:22   error  <form> element must have a submit button                                   wcag/h32
  105:34   error  <button> is missing required "type" attribute                              element-required-attributes
  106:42   error  Attribute "aria-hidden" used ' instead of expected "                       attr-quotes
  106:61   error  Attribute "focusable" used ' instead of expected "                         attr-quotes
  106:79   error  Attribute "height" used ' instead of expected "                            attr-quotes
  106:93   error  Attribute "version" used ' instead of expected "                           attr-quotes
  106:107  error  Attribute "viewBox" used ' instead of expected "                           attr-quotes
  106:127  error  Attribute "width" used ' instead of expected "                             attr-quotes
  106:140  error  Attribute "xml:space" used ' instead of expected "                         attr-quotes
  106:161  error  Attribute "style" used ' instead of expected "                             attr-quotes
  106:161  error  Inline style is not allowed                                                no-inline-style
  106:248  error  Attribute "xmlns:xlink" used ' instead of expected "                       attr-quotes
  106:291  error  Attribute "xmlns" used ' instead of expected "                             attr-quotes
  106:326  error  Attribute "class" used ' instead of expected "                             attr-quotes
  116:34   error  <button> is missing required "type" attribute                              element-required-attributes
  117:42   error  Attribute "aria-hidden" used ' instead of expected "                       attr-quotes
  117:61   error  Attribute "focusable" used ' instead of expected "                         attr-quotes
  117:79   error  Attribute "height" used ' instead of expected "                            attr-quotes
  117:93   error  Attribute "style" used ' instead of expected "                             attr-quotes
  117:93   error  Inline style is not allowed                                                no-inline-style
  117:198  error  Attribute "version" used ' instead of expected "                           attr-quotes
  117:212  error  Attribute "viewBox" used ' instead of expected "                           attr-quotes
  117:232  error  Attribute "width" used ' instead of expected "                             attr-quotes
  117:245  error  Attribute "xml:space" used ' instead of expected "                         attr-quotes
  117:266  error  Attribute "xmlns:xlink" used ' instead of expected "                       attr-quotes
  117:309  error  Attribute "xmlns" used ' instead of expected "                             attr-quotes
  117:344  error  Attribute "class" used ' instead of expected "                             attr-quotes
  126:122  error  Attribute "required" should omit value                                     attribute-boolean-style
  126:142  error  Expected omitted end tag <input> instead of self-closing element <input/>  void-style
  130:125  error  Attribute "required" should omit value                                     attribute-boolean-style
  130:145  error  Expected omitted end tag <input> instead of self-closing element <input/>  void-style
  135:138  error  Attribute "required" should omit value                                     attribute-boolean-style
  135:158  error  Expected omitted end tag <input> instead of self-closing element <input/>  void-style
  139:150  error  Attribute "required" should omit value                                     attribute-boolean-style
  139:170  error  Expected omitted end tag <input> instead of self-closing element <input/>  void-style
  143:74   error  Redundant "for" attribute                                                  no-redundant-for
  144:124  error  Expected omitted end tag <input> instead of self-closing element <input/>  void-style
  151:34   error  <button> is missing required "type" attribute                              element-required-attributes

What do you think about its rules?
May I start sending PR-s?

Jump on selection

When an item is selected in the responsive table the whole table jumps to make space for the selection bar.
That is bad.

Greatly improved SVG handling

  • Fix html-validate's attr-quotes rule: always use double quotes
  • Less modules: no himalaya
  • Less filters: no "svgIcon"

Example

{{ '/src/img/icon/minus.svg' | svgContents('btn__icon') | safe }}

From #1 (comment)

Would you merge a PR touching 58 lines?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.