Giter VIP home page Giter VIP logo

Comments (5)

irwalker avatar irwalker commented on July 18, 2024 1

I'm going to mark this as closed since the change was mentioned in the Changelog; I think it would be better if there was a breaking changes section in release docs to make this more obvious in future releases 😄.

Thanks again for the quick response

from ruby-sdk.

z4kn4fein avatar z4kn4fein commented on July 18, 2024

Hi @irwalker, thanks for reporting this issue! We started to work on the fix. I'll notify you when it's released.

from ruby-sdk.

z4kn4fein avatar z4kn4fein commented on July 18, 2024

Hi @irwalker, it turned out that the example test uses the wrong type for the local dictionary override definition.
This is the correct one:

flag_overrides = LocalDictionaryFlagOverrides.new(
  { some_feature: "yes" },
  OverrideBehaviour::LOCAL_ONLY,
  )

So, instead of LocalDictionaryDataSource.new(), it must be LocalDictionaryFlagOverrides.new().
Did you find LocalDictionaryDataSource.new() in the docs or examples? I'm just asking because I'd also fix it there if that's the case.

from ruby-sdk.

irwalker avatar irwalker commented on July 18, 2024

Thanks for the quick response on this @z4kn4fein!

Prior to 6.0 we were using ConfigCat::LocalDictionaryFlagOverrides.new which worked OK - the dev who implemented this in our system looked at the gem source to figure out which class to use.

Using LocalDictionaryFlagOverrides.new appears to have solved our problem.

Note that if I use LocalDictionaryFlagOverrides.new in our code prior to the 6.0 update it is not defined.

, [2023-06-21T16:52:36.958455 #42326] ERROR -- : #<NameError: uninitialized constant ConfigCat::LocalDictionaryFlagOverrides
ConfigCat::LocalDictionaryFlagOverrides.new(

Also, I just realised this was documented in the Changelog 🤦

from ruby-sdk.

z4kn4fein avatar z4kn4fein commented on July 18, 2024

Yeah, you're right, we'll do it that way next time. Thanks for the feedback!

from ruby-sdk.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.