conflux-chain / conflux-doc Goto Github PK

Actual mining.notify:

{
"id": 316399, 
"method": "mining.notify", 
"params": 
[
"0xce93239b792b149ae5ee664883fa42ce01f94c4759d666fb096627732a309914", 
"4985137", 
"0xce93239b792b149ae5ee664883fa42ce01f94c4759d666fb096627732a309914",
"0x2641ed57a336dee002ccf83f2b4c1c0d0a7fb3f49cdefaec33d5780"
] 
}

Docs:

Parameters
JOB_ID, hex-string - the identifier of the job.
HASH, 32-bytes - the hash of the PoW problem.
BOUNDARY, U256 - the difficulty boundary of the problem. For a nonce to be valid, the resulting hash must be smaller than the BOUNDARY.
Example

// Request
'{
"jsonrpc":"2.0",
"method":"mining.notify",
"params":
[
"0x4e08db21d43a7696afa3d00ed948568210f3ab3f34673f1d17198625ec175a9c",
"0x4e08db21d43a7696afa3d00ed948568210f3ab3f34673f1d17198625ec175a9c",
"0x1a4e3422948568210f3ab3f34673f1d17198625ec175a9c"
],
"id":3}'

Please update the docs with the correct params representation

In the current implementation, the gas price of CREATE and CREATE2 follows the same definition as in Ethereum:
CREATE costs G_create,
CREATE2 costs G_create+G_sha3word × ⌈μ [2] ÷ 32⌉,
where the additional cost of CREATE2 corresponds to hashing on the initialization code of length μ [2] bytes.

Actually, the difference in gas price in Ethereum is introduced because the resultant contract address by CREATE is simply the rightmost 160-bits of Kec(RLP(s,n)) without the hash value of initialization code where as the address by CREATE2 includes such a hash value.

In Conflux we include the hash value of initialization code in both cases of CREATE and CREATE2, so that the discrimination in gas price does not make much sense.
Therefore I think it would be better if we change the price of CREATE to the same as CREATE2.

https://github.com/Conflux-Chain/conflux-doc/blob/master/docs/key_management.md

You can download the key management toolkit of Conflux (keymgr) from [here] ()

but the index of "here" is not the correct download url, beacuse this link to: https://github.com/Conflux-Chain/conflux-doc/blob/master/docs

https://conflux-chain.github.io/conflux-doc/get_started/

To run python integration tests, it says:
$ ./test/test_all.py
but there is no such directory, which is actually at:
$ ./tests/test_all.py

It would be nice if we could browse the API of a specific node version. Something like this.