Giter VIP home page Giter VIP logo

conformance's People

Contributors

akshayjshah avatar alfus avatar bufdev avatar chrispine avatar cyinma avatar dependabot[bot] avatar doriable avatar jchadwick-buf avatar jhump avatar nicksnyder avatar pkwarren avatar rebello95 avatar rubensf avatar smallsamantha avatar smaye81 avatar srikrsna-buf avatar timostamm avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

kooksee luizjunior05 srikrsna-buf jchadwick-buf

conformance's Issues

Server-side implementation of FailServerStreaming is incorrect

https://github.com/bufbuild/connect-crosstest/blob/3ceac5de26818d775fd345ea33da1b5093120072/internal/interop/interopconnect/test_server.go#L121 isn't quite right - we're supposed to be sending one message and then an error. Instead, we're sending an error immediately.

This is important, because the two behaviors exercise different code paths: sending an error right away lets the server send a trailers-only response (which is confusingly just HTTP headers with no body). Sending a message and then an error forces the server to encode the trailing metadata (including all the error information) at the end of the body. grpc-web treats header keys as case-insensitive in the first case but case-sensitive in the second case.

I believe that this has allowed a protocol bug to sneak into connect-go - we're not lowercasing HTTP/1.1 header and trailer names when speaking the gRPC-Web protocol. I've got an issue open on the spec to clarify expectations here, but we should update this test case to correctly expose the incompatibility.

@joshcarp can you take a look at this?

Drop `caseless` in JS tests

Header and trailer key casing is an important detail of the gRPC-Web specification. We should not be using the caseless NPM package. Instead, we should verify that connect-go and Envoy use exactly the same casing.

@joshcarp can you take a look at this one too?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.