Hi,

After entering all of the information for Binance deployment, I am getting the following error when running node deploy.js:
TypeError: Cannot read property 'fromRed' of null

/Users/vlad/Documents/_DEV/chaindata/node_modules/elliptic/lib/elliptic/curve/short.js:415
  return this.x.fromRed();
                ^

TypeError: Cannot read property 'fromRed' of null
    at Point.getX (/Users/vlad/Documents/_DEV/chaindata/node_modules/elliptic/lib/elliptic/curve/short.js:415:17)
    at Point._encode (/Users/vlad/Documents/_DEV/chaindata/node_modules/elliptic/lib/elliptic/curve/base.js:300:16)
    at Point.encode (/Users/vlad/Documents/_DEV/chaindata/node_modules/elliptic/lib/elliptic/curve/base.js:309:28)
    at KeyPair.getPublic (/Users/vlad/Documents/_DEV/chaindata/node_modules/elliptic/lib/elliptic/ec/key.js:66:19)
    at new SigningKey (/Users/vlad/Documents/_DEV/chaindata/node_modules/@ethersproject/signing-key/lib/index.js:22:71)
    at new Wallet (/Users/vlad/Documents/_DEV/chaindata/node_modules/@ethersproject/wallet/lib/index.js:123:36)
    at Object.<anonymous> (/Users/vlad/Documents/_DEV/chaindata/deploy.js:59:16)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)

In terms of changes, I've only updated the required 39 - 55:

const provider = new ethers.providers.JsonRpcProvider('https://bsc-dataseed1.binance.org/');
const verifyURL = 'https://api.bscscan.com/api';
const privateKey = Buffer.from('0x1e...', 'hex');
const apikey = 'VKVS...';

const mpcAddress = '0x533e3c0e6b48010873B947bddC4721b1bDFF9648';
const signer = new ethers.Wallet(privateKey, provider);
const constructorArgs = ['<name>', '<symbol>', '18', '', signer.address];

Any guidance would be super appreciated. Thank you!

Description

When we recently used the fuzz testing tool, we scanned the contract AnyswapV4ERC20.sol. We found some issues and wanted to confirm with you.

    function depositWithPermit(address target, uint256 value, uint256 deadline, uint8 v, bytes32 r, bytes32 s, address to) external returns (uint) {
        IERC20(underlying).permit(target, address(this), value, deadline, v, r, s);
        IERC20(underlying).safeTransferFrom(target, address(this), value);
        return _deposit(value, to);
    }

WETH does not implement the permit function specified by ERC20 and implements the fallback function. At the same time, the permit function has no return value, so no error will be reported when calling WETH's permit function. If the underlying address is the address of the WETH contract, will there be such a problem?

Hi,

There is a logical error in one of the require in transferWithPermit:

require(to != address(0) || to != address(this));

it should be

require(to != address(0) && to != address(this));

otherwise it has no sens as to=address(this) will pass.

Hi. one question about ContractAddress on https://github.com/connext/chaindata/blob/main/deploy.md
I'm gonna integrate the pre-deployed ERC20 token to the cross-chain bridge.
So I'm gonna build a wrapper contract for the ERC20 token.

I checked the Anyswap frontend. In most cases, the deposit address is the same as MPC address. When we use a wrapper, which one of Wrapper and ERC20 token should be set as a contract address?
Thanks

Hi - is there a reason theres duplicate functionality? setVault/changeVault seem to do the same thing. ChangeMPCOwner is also really similar, the only difference is that it's a public function instead of external
Link to code:
https://github.com/connext/chaindata/blob/main/AnyswapV4ERC20.sol#L203
https://github.com/connext/chaindata/blob/main/AnyswapV4ERC20.sol#L224
https://github.com/connext/chaindata/blob/main/AnyswapV4ERC20.sol#L232

From this markdown main/deploy.md i found out if i already have a token deployed i would need to:

Deploy a wrapper for your token that supports mint, burn, Swapin, and Swapout, add this wrapper as a minter role in the ACL. In the wrapper add the MPC address (found below) as a minter

Could you by any chance consider writing or pointing me to a more detailed guide on this topic?

Just to add some context here, i'm trying to deploy The Aluna Token to multiple chains, currently it's only available on Ethereum main net.

Our token was deployed using the Proxy Patter ( standard OpenZeppelin ) so we could update it with the necessary functions to a new implementation, but after having a look at AnyswapV5ERC20.sol it's not very clear what the best approach would be.

There are a few key questions here:

• Our token isn't ERC20Mintable, but we need to implement it in order to be able to have MPC address as a minter, correct?
• Our token is already an ERC20Burnable.sol but from reading AnyswapV5ERC20.sol i can tell the burn function works slightly different on AnyswapV5ERC20.sol than on ERC20Burnable.sol, that's the reason why we need a Wrapper for our ERC-20? Is there a Wrapper Example for ERC-20 anywhere?

Thank You

Hi, we recently have conducted a systematic study about Solidity event usage, evolution, and impact, and we are attempting to build a tool to improve the practice of Solidity event use based on our findings. We have tried our prototype tool on some of the most popular GitHub Solidity repositories, and for your repository, we find a potential optimization of gas consumption arisen from event use.

The point is that when we use emit operation to store the value of a certain variable, local memory type variable would be preferable to global storage type (state) variable if they hold the same value. The reason is that an extra SLOAD operation would be needed to access the variable if it is storage type, and the SLOAD operation costs 800 gas.

For your repository, we find that the following event use can be improved:

• AnyswapV5ERC20.sol
  function name: changeVault
  event name:  LogChangeVault
  variable:    pendingVault->newVault

    function changeVault(address newVault) external onlyVault returns (bool) {
        require(newVault != address(0), "AnyswapV3ERC20: address(0x0)");
        pendingVault = newVault;
        delayVault = block.timestamp + delay;
        emit LogChangeVault(vault, pendingVault, delayVault);
        return true;
    }

  function name: changeMPCOwner
  event name:  LogChangeMPCOwner
  variable:    pendingVault->newVault

    function changeMPCOwner(address newVault) public onlyVault returns (bool) {
        require(newVault != address(0), "AnyswapV3ERC20: address(0x0)");
        pendingVault = newVault;
        delayVault = block.timestamp + delay;
        emit LogChangeMPCOwner(vault, pendingVault, delayVault);
        return true;
    }

• AnyswapV4ERC20.sol
  function name: changeVault
  event name:  LogChangeVault
  variable:    pendingVault->newVault

    function changeVault(address newVault) external onlyVault returns (bool) {
        require(newVault != address(0), "AnyswapV3ERC20: address(0x0)");
        pendingVault = newVault;
        delayVault = block.timestamp + delay;
        emit LogChangeVault(vault, pendingVault, delayVault);
        return true;
    }

  function name: changeMPCOwner
  event name:  LogChangeMPCOwner
  variable:    pendingVault->newVault

    function changeMPCOwner(address newVault) public onlyVault returns (bool) {
        require(newVault != address(0), "AnyswapV3ERC20: address(0x0)");
        pendingVault = newVault;
        delayVault = block.timestamp + delay;
        emit LogChangeMPCOwner(vault, pendingVault, delayVault);
        return true;
    }

Do you find our results useful? Your reply and invaluable suggestions would be greatly appreciated, and are vital for improving our tool. Thanks a lot for your time!