consensys / besu-plugins Goto Github PK

Description

In the doc https://docs.plus.pegasys.tech/en/stable/Reference/CLI-Syntax/#plugin-kafka-log-filter-addresses it seems that we can put several contract addresses on this field --plugin-kafka-log-filter-addresses . If we try to put more than one we get an error message

Steps to Reproduce (Bug)

1. Start Besu with the Kafka plugin and this CLI option

--plugin-kafka-log-filter-addresses=0x42699A7612A82f1d9C36148af9C77354759b210b,0x42699A7612A82f1d9C36148af9C77354759b210c

Expected behavior: [What you expect to happen]
To be able to put several contract addresses without having errors

--plugin-kafka-log-filter-addresses= 0x42699A7612A82f1d9C36148af9C77354759b210b,0x55699A7612A82f1d9C36148af9C77354759b210c

Actual behavior: [What actually happens]
Crash with this error

Invalid value for option '--plugin-kafka-log-filter-addresses' (): cannot convert '0x42699A7612A82f1d9C36148af9C77354759b210b,0x42699A7612A82f1d9C36148af9C77354759b210c' to Address (java.lang.IllegalArgumentException: Hex value is too large: expected at most 20 bytes but got 42)

Frequency: 100%

Versions (Add all that apply)

• Software version
  • Besu : 20.10.1-SNAPSHOT
  • Kafka Plugin : 1.0.0-SNAPSHOT
• Java version: [java -version]

openjdk version "13.0.2" 2020-01-14
OpenJDK Runtime Environment AdoptOpenJDK (build 13.0.2+8)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 13.0.2+8, mixed mode, sharing)

Description

As a Besu node admin I would like to be able to disable specific topics in the event stream feature so that topics that I don't need are not published to the broker. For instance, disable the Blocks topic.

Acceptance Criteria

• Be able to disable a specific topic using the usual configuration system
• Default should be the current behaviour with all topics enabled
• Displaying disabled/enabled topics in a log when starting would be a plus

Expected behavior: [What you expect to happen]

Only non disabled topics events will be published

Actual behavior: [What actually happens]

All topics are published

Additional Information

This feature request is inspired by a customer question