constantcontact / ctct_php_library Goto Github PK

For example on [email protected]. This is a valid email address per gmail policy, and will deliver to [email protected]

I've used your library and can successfully use the OAuth2 server flow to access the CTCT API and retrieve data. I've subclassed CTCTDataStore to store access credentials in database instead of a specific user session, but find I find CTCTDataStore is being called anyway and not by subclass. This causes the API request to fail since the session data doesn't contain current credentials.

Should I be registering my subclass somewhere? Do you have an example of using your library where CTCTDataStore is reimplemented?

This script will not work on debian wheezy when it comes out (php5.4/curl 7.26) because the CTCT servers will reject the connection (as an added bonus, the process ties down the entire server for 30 seconds or so). For my configuration, this was fixed by adding the following to line 1117 of Authentication.php

curl_setopt($curl, CURLOPT_SSLVERSION,3);

I do not know what effects this might have on other configurations.

According to CC, email address searches are case-sensitive, so it might be helpful to add a strtolower() in your API so it doesn't trip up people using it and expecting different results.

I don't know if this should be classified as a true issue or not, but the OAuthException class in Authentication.php collides with the predefined OAuthException class included with the default php installation, at least on Amazon Web Services.

Hi!

I'd like to propose that this Constant Contact PHP library be completely refactored to include the following:

• Unit test coverage
• Travis-CI integration
• Proper autoloading
• PSR0 compliance
• Proper coding standards (PSR1/PSR2)
• Composer/Packagist support

The current Constant Contact PHP library is unusable for many large companies who cannot use third party code that is not properly tested.

I have started this refactoring in my feature/refactoring branch on my fork. Any feedback would be welcome.

    } catch(CTCTException $e) {
        $e->generateError();
    }
    return $return;

Right at the end of Authentication.php. Errors aren't thrown up the stack, so if anything goes wrong an error is generated but the library goes on acting if nothing happened. As of right now, this means if someone submits incorrect authentication information it's impossible to do anything without simplexml_load_xml($response['xml']) throwing an error - there's no way to tell whether or not a user's actually authenticated! This carries over to if anything goes wrong - it gets passed back as if it's valid information and there's no way for a developer to verify whether or not a call executed successfully.