contributte / image-storage Goto Github PK

If file has two dots in filename (img.2.jpg) final URL is broken => ..data/d7/img.100x100.fit.q100.2.jpg instead of img.2.100x100.fit.q100.jpg

Hi,

First of all, thanks for this package. It currently suits my needs really well and improves the way I handle images in general.

I stumbled upon this issue. When an image is not found, it stops working because of the assert over here: image-storage/src/ImageStorage.php:281.

It is deprecated to use assert with string since PHP 7.2.0.

I am using PHP 7.3 and contributte/image-storage 2.0.5.

Cheers,
Patrik

Chyba:
Declaration of Contributte\ImageStorage\ImageStoragePresenterTrait::createTemplate(): Nette\Application\UI\ITemplate must be compatible with Nette\Application\UI\Presenter::createTemplate(?string $class = null): Nette\Application\UI\Template

při vytváření traity v souboru ImageStoragePresenterTrait.php řádek č.19

If the image is not found and is replaced by a definition in the configuration (default noimage_identifier: images/noimage/no-image.png) the path is not correctly parsed by the fromName method because the string "images/noimage/no-image.png" does not pass the preg_match pattern and the array is zero.

The solution was to set "noimage/01/no-image.png" in the configuration.

Hello,
I wanted to show image of user in datagrid, however Image::createLink method returns path without the $basePath variable.

public function columnName(User $user): Html
{
	$presenter = $this->getPresenter();
	$basePath = $presenter->getHttpRequest()->getUrl()->getBasePath();

	// Avatar
	$image = $this->imageStorage->fromIdentifier($user->getImage());
	$avatar = Html::el('img class="img-fluid img-circle mr-2" width="24px" alt="'.$user.'"')
		->setSrc($basePath.$image->createLink());

	// Link
	$link = $presenter->lazyLink('User:edit', $user->getId());
	$name = Html::el('a')->setHref($link)->addHtml($avatar)
		->addText($user->getName());

	return $name;
}

Ma byt:
Ublaboo\ImageStorage\DI\ImageStorageExtension

Would it be possible to support latte/latte:3? I don't know how complicated that might be.

Thanks for considering this,
Patrik

ImageStorage.php:123

If $script->name contains path (for me occurs when namespace is used) than RE failed. It is necessary to use preg_quote( $script->name, '/' ) to prevent such situation.

Prosím, kdy bude verze pro Nette 3.0?

i have original images in private path
eq. ROOT/assets/images...

i call from template macro {img images/123.jpg...} and i want resized images generate in public path
eq. ROOT/www/data/mages....

original images not be access from website...

Please, can you advise me how to add size/crop parameters to latte {img} macro? Is that even possible following this documentation? https://github.com/contributte/image-storage/tree/master/.docs#transforming-image---resizing-cropping

something like {imgLink //$image, '500x282', 'exact'} or {absImgLink} ? return same as {$baseUrl}{imgLink $image}

error in ImageStorage:284

TypeError : Return value of Contributte\ImageStorage\ImageStorage::getNoImage() must be an instance of Contributte\ImageStorage\Image, array returned

version: v2.0.0
hash: 70b37fb

Hi,
I have a question about quality of images. The quality is set with equal alue for both (jpg and png) types, but internally it uses the imagejpeg method for JPG (quality from 0 to 100) and imagepng for PNG (there is quality option from 0 to 9 - lower bigger quality). So the quality for these types is completely different at the result.

What we can to do with that? Thank you.

http://ublaboo.paveljanda.com/image-storage/get-and-transform - return error 500