Tag in GitHub compare link incorrectly prefixed with a 'v' about conventional-changelog-core HOT 11 CLOSED

The PR has not been merged yet

from conventional-changelog-core.

I already checked if git log --decorate --no-color contains the correct tags and it does. So the issue is not in git-semver-tags.

from conventional-changelog-core.

Can you provide an easy way to replicate your problem?

from conventional-changelog-core.

I forked standard-version and created two tags without the v-prefix: https://github.com/SteveVanOpstal/standard-version/releases

When I run node index.js standard-version creates this compare link:
conventional-changelog/standard-version@2.2.3...v2.2.2

from conventional-changelog-core.

I see what you mean now... context.currentTag by default is 'v' + context.version. You could always change the defaults.

from conventional-changelog-core.

The changelog is generated before you tag it. That means it doesn't know what you're gonna tag it. You could tag it as anything basically. It's not recommended to do that.
If you really want to do that and doesn't want to change context.currentTag manually, you could generate the changelog after you tag it.

from conventional-changelog-core.

The main reason why I have non-v-prefixed tags is because I have set up my project similarly as the angular project. There was also a recent addition to semver that made me lean more towards non-v-prefixed tags:
https://github.com/mojombo/semver/blob/master/semver.md#is-v123-a-semantic-version

However, for my convenience and also because I just discovered the pretty awesome standard-version repository, I can drop my autistic ideas and go for v-prefixed tags.

from conventional-changelog-core.

All defaults are meant to be configurable. But using them is highly recommended. Maybe the default v should be depending on the previous tag?

from conventional-changelog-core.

Seems like a good solution. The only situation that is not covered is when a repository moves from one prefix type to the another, but this is something that probably won't happen often and it is very easy to fix manually, and only needs to be fixed once. Are there any other situations/prefixes we should consider though?

from conventional-changelog-core.

Are there any other situations/prefixes we should consider though?

I can't think of any.

from conventional-changelog-core.

Me neither

from conventional-changelog-core.