Giter VIP home page Giter VIP logo

Comments (2)

stevemao avatar stevemao commented on June 6, 2024

A bit more details would be appreciated. Or even better, send a PR.

from conventional-changelog-core.

vankeer avatar vankeer commented on June 6, 2024

Thanks for the response. Here's an example of what goes wrong in our case: https://github.com/vankeer/conventional-changelog/commit/2eb757356b6e3d7c22cc95c3fea8174b91b41fbb

Basically, our Git repo is hosted on a local Stash instance (see the package.json in the commit for an example of the URL). get-pkg-repo apparently can't extract the project from the URL, but it can get the domain. So if you look at the lib/merge-config.js code on line 143: context.host is defined, the rest isn't, so the repository URL isn't set to browse.

One possible fix (other than perhaps changing get-pkg-repo) would be reverting the change to lib/merge-config.js as I don't understand why context.repository = context.repository || repo.project || browse; was not ok, but I'm not aware of the context of the fix

from conventional-changelog-core.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.