convergencelabs / monaco-collab-ext Goto Github PK

I have a project using this with Webpack and React.

Currently I'm importing by:

import * as MonacoCollabExt from "@convergencelabs/monaco-collab-ext";

This was counterintuitive, and took me a while of debugging Webpack errors to figure out.

I think it's more intuitive to import with

import MonacoCollabExt from "@convergencelabs/monaco-collab-ext";

or even

import { MonacoCollabExt } from "@convergencelabs/monaco-collab-ext";

The docs say that it's compatible with monaco-editor versions >=0.15.6 <=0.21.x but gives an error:
Type 'ICodeEditor' is missing the following properties from type 'ICodeEditor': onDidCompositionStart, onDidCompositionEnd, onDidAttemptReadOnlyEdit, onDidPaste, and 12 more.

I checked the function names are onCompositionStart, onCompositionEnd, onAttemptReadOnlyEdit, etc.

Hello,
I am facing issue in building react application having this dependency. I am getting error in with the unnecessary monaco files which II guess not required for collab extension.

Module parse failed: Unexpected token (156:11)
File was processed with these loaders:
 * ./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|     dispose() {
|       onLanguageListener.dispose();
>       mode?.dispose();
|       mode = void 0;
|     }

If I rebuild the monaco-collab-ext with replacing import * as monaco from "monaco-editor" with import * as monaco from "monaco-editor/esm/vs/editor/editor.api" Then the above issue is not coming and everything works fine. So, my suggestion is why not to just import monaco api's instead of whole heavy monaco editor installation. If other things not required.
Also, on searching everywhere the above error could also be solved by changing webpack configuration. But my doubt is why to go into hassle of changing/overriding webpack config, if it could easliy solve by importing monaco api only.

What is the opinion about this issue?

When remote cursor is added at the last line of the editor (see red cursor at the screenshot) the tooltip is hidden:

Obviously it happens only when there is not enough space at the editor bottom. But I guess the behaviour in this particular case should be the same like with a completion menu. Tooltip shouldn't be cut by the editor borders.

There is a flag IContentWidget.allowEditorOverflow which could help to resolve the problem, however I'm not sure.

I tried to visit https://examples.convergence.io/examples/monaco/ (looks like https://docs.convergence.io/guide/ is also down) but DNS is not resolving the domain:

I ran on monaco 0.19.0 and cursors doesn't work:

“"cssMode.js?db4f:54 Uncaught (in promise) TypeError: monaco.languages.registerSelectionRangeProvider is not a function””

It’s may help: Monaco-editor did breaking changes: getConfiguration() is replaced by getRawOptions(), which returns the passed in editor options.

Hello, I have a question

Is there any way to load [monaco-collab-ext] through script src and use it?

Visiting https://examples.convergence.io/monaco/index.html referenced in Readme returns a 404.

Would it be better to movemonaco-editor from dependencies to peerDependencies in package.json?

Also, monaco-editor-core might be better than monaco-editor?