Giter VIP home page Giter VIP logo

Comments (7)

cookpete avatar cookpete commented on August 23, 2024 1

No problem Kai. I quite like the idea of enforcing clean output :)

I'm curious why you only got one type of linting error from that vscode package. The default lint config meant I had to ignore more than one rule:

https://github.com/CookPete/auto-changelog/blob/7dbc2b7d30ceec593477b1bd43ecc7731193c9cc/.markdownlintrc#L1-L7

Whereas their standard config seems to only ignore the line-length rule:

https://github.com/DavidAnson/vscode-markdownlint/blob/d2dc3e83aee7a5a41c2ec7e67901dfbd2b6e7e4f/default-config.json#L1-L3

from auto-changelog.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 23, 2024

ty Pete!

from auto-changelog.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 23, 2024

mhm maybe I haven't noticed it prior, but their checks are complaining about first headline not being top level heading h1.

https://github.com/DavidAnson/markdownlint/blob/v0.10.0/doc/Rules.md#md002
when corrected, you then have also to review all #### headline to ##
https://github.com/DavidAnson/markdownlint/blob/v0.10.0/doc/Rules.md#md001

Maybe you can review that too? :)

from auto-changelog.

cookpete avatar cookpete commented on August 23, 2024

Yeah I've added "first-header-h1": false to the custom lint config. You may have to add your own lint config to ignore it too. I don't really want to adjust the headers for the default template as they become too big for a changelog that is supposed to be compact.

from auto-changelog.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 23, 2024

Ok, ty for your response. As we keep our other markdown files aligned their checks we can't set this to auto-ignore. we will keep our eyes then closed for the changelog ;-)

from auto-changelog.

cookpete avatar cookpete commented on August 23, 2024

Aha sorry Kai :) Maybe you could ignore the changelog file in the markdownlint options? It would make 5086228 a bit redundant but I suppose it was nice to clean up the output.

from auto-changelog.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 23, 2024

ah thanks for pointing on this, will have an eye on that too.

from auto-changelog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.