When launching the website locally I have to remove the sessions file each time. I think it's because of the difference between the local user ID and the docker user ID.

This fix on SO should work.

Can I apply it @alexsegura ?

There is a ConfigLoader.js class which allows to parse *.yml in JavaScript like Symfony.

It should be tested against a few use cases to make sure it works correctly.
Maybe even test it against the test suite used by Symfony?

Also, it has a few bugs, for example it doesn't load numeric arrays correctly

Should be easy, at least it needs:

• a PostgreSQL container with PostGIS extension
• a Redis container
• a container to run Node

Sur Safari 6.2.8, MacOS10.8.5, l'ouverture de la page https://coopcycle.org/fr/ échoue car "Safari ne peut pas ouvrir une connexion sécurisée vers coopcycle.org"

On my machine (OSX Yosemite), the PHP container is damn slow to responds when developing in the browser.

Do you have the same issue?

The following warning is emitted on Travis

(node:8284) DeprecationWarning: PG.connect is deprecated - please see the upgrade guide at https://node-postgres.com/guides/upgrading
(node:8284) DeprecationWarning: Using the automatically created return value from client.query as an event emitter is deprecated and will be removed in [email protected]. Please see the upgrade guide at https://node-postgres.com/guides/upgrading

Webpack build currently takes up to 4 minutes to complete.
This is way too long.

We need to find ways to reduce the build time.

The best practice seems to be using always database 0 to store all production data, prefixing keys with namespaces.

I think most people are used to login with their emails. Would that be possible to enable login by email and username OR only login with email?

The coopcycle:demo:init command should accept arguments to specify the number of items to create, for example:

php bin/console coopcycle:demo:init --restaurants=100 --couriers=50 --users=50

Currently we use Underscore.js, we should use Lodash as it is already used by everybody.

• Use OSRM for routing
• Use LeafletJS to draw maps
• Use Pelias for geocoding

We are serializing classes following schema.org vocabulary.

Right now, property names in PHP classes are the same as in JSON responses, for example Menu.hasMenuItem

We should use normalizers to keep PHP classes clean.

For example, in the Menu class the property should be named sections, while being serialized as hasMenuSection.

The annotation @ApiResource is used in the RestrictedDiet php class but without the call to the vendor's class : use ApiPlatform\Core\Annotation\ApiResource; it will crash

As recommended by Google, some pages should have JSON-LD data, at least the restaurants.

In Capistrano deploy file, the migrations are executed every time

On the first deploy the schema does not exist yet.

I'm such a n00b...

Right now the osrm-docker Ansible role configures Supervisor to start the Docker containers.
It doesn't work at all: Supervisor has no clue to check if the process is running, and when there is an error, it starts containers forever.

Instead we should use Ansible's docker_container to start & manage the containers.
Also see restart policies to handles system reboots.

Quick check : (typeof $().modal == 'function'); returns false and bootstrap.js is well loaded => jQuery loaded twice and overrides bootstrap.js (which is a jQuery plugin).

Not sure how to fix it, maybe we could use the CommonsChunkPlugin to load jQuery only once.

There is always this error when restarting Docker.

Warning: SessionHandler::read(): Session data file is not created by your uid

To fix it

rm -rf var/sessions/dev

We need to remove sessions folder on startup.

Sometimes the Travis build fails on Mocha tests. They are timing out.
Most of the time, clicking on "Restart build" solves the issue.

We need to make sure tests run correctly on each build.

We need to manage registration through external websites & native apps.

As a first implementation, there is a register endpoint which automatically activates the user.
But this seems not really satisfying, at least it could lead to lots of spam.

How to manage email verification anyway?
Is there a better way with API Platform?

First migrations is here and suppose there are already some tables created in the DB (menu_item, restaurant, aso).

It is not very clean, the migration process should work from scratch, so we can use doctrine:migrations:migrate .

Do we need to keep Entity\MenuSection and Entity\MenuItem ? AFAIK we only use Entity\Menu\MenuSection and Entity\Menu\MenuItem

In user profile, allow to update/delete addresses.
For now, we need to use soft delete, until we freeze addresses in order.

Currently we use file_get_contents, we should use Guzzle.

I would suggest to move js/app to assets/js/components or assets/js/scripts and rename js/api to api , as it is not clear what does what in my opinion.

We shouldn't be interacting directly with the database here

$ bin/console fos:user:promote --help

Usage:
  fos:user:promote [options] [--] <username> [<role>]

Arguments:
  username              The username
  role                  The role

When using OSRM server, directions may be outside the available road network.
In this case, an empty response is returned.

This should trigger an error.

We should add a tool to check the coding style / code coverage.

Code Climate looks nice.

http://symfony.com/blog/new-in-symfony-3-3-manifest-based-asset-versioning

Currently, dispatch loops over a Redis list using the circular list pattern

Maybe it could be a good idea to use generators to loop over the orders?

This would save time and efforts to, at least to compile OSRM

https://github.com/Project-OSRM/osrm-backend/wiki/Docker-Recipes

Host for webpack-dev-server is hardcoded for Docker

Maybe use environment variables with dotenv file?

http://symfony.com/doc/current/configuration/external_parameters.html

http://symfony.com/doc/current/session/locale_sticky_session.html

• Remove Vagrant install instructions
• Move architecture description to the Wiki
• Remove refs to 192.xxx (since docker for mac exists)
• Add doc for demo command

Allow dividing cities into districts with bounding boxes

This would allow to group restaurants for example, and also assign couriers to districts.

Ideally fences should be editable by an administrator via a web user interface.

Data in KML format looks easy to parse, example for Paris

It should be easy to create a bot that connects to the dispatch service, accepts orders and delivers them, using the Google Directions API to find the best route.

The GoogleDirectionsApi class implements the RoutingInterface so they need to implements this two methods :

    public function getRawResponse(GeoCoordinates $origin, GeoCoordinates $destination)
    {
        // TODO: Implement getRawResponse() method.
    }

    public function getDistance(GeoCoordinates $origin, GeoCoordinates $destination)
    {
        // TODO: Implement getDistance() method.
    }

Without theses 2 methods php will crash

The class : AuthenticationWebSuccessHandler use an unknown variable $referer at line 23

Sur Firefox (v48.0.2), MacOS10.8.5, l'ouverture de la page https://coopcycle.org/fr/ bloque le navigateur. Qui tourne à +100% CPU. Un script dans une boucle infinie ?

It looks like the integrity key is modified from sha1 to sha512

git diff package-lock.json
diff --git a/package-lock.json b/package-lock.json
index 44ed3ff..5e32cf0 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5781,7 +5781,7 @@
     "npmlog": {
       "version": "4.1.0",
       "resolved": "https://registry.npmjs.org/npmlog/-/npmlog-4.1.0.tgz",
-      "integrity": "sha1-3Fm+6F9k8A7UJO+yrweD3yXRwLU=",
+      "integrity": "sha512-ocolIkZYZt8UveuiDS0yAkkIjid1o7lPG8cYm05yNYzBn8ykQtaiPMEGp8fY9tKdDgm8okpdKzkvu1y9hUYugA==",
       "dev": true,
       "requires": {
         "are-we-there-yet": "1.1.4",
@@ -9259,7 +9259,7 @@
     "wide-align": {
       "version": "1.1.2",
       "resolved": "https://registry.npmjs.org/wide-align/-/wide-align-1.1.2.tgz",
-      "integrity": "sha1-Vx4PGwYEY268DfwhsDObvjE0FxA=",
+      "integrity": "sha512-ijDLlyQ7s6x1JgCLur53osjm/UXUYD9+0PbYKrBsYisYXzCxN+HC3mYDNy/dWdmf3AwqwU3CXwDCvsNgGK1S0w==",
       "dev": true,
       "requires": {
         "string-width": "1.0.2"

Se this issue npm/npm#17749

cc @Atala

The RestrictedDiet use a vendor called : MyCLabs\Enum\Enum which use the library : https://github.com/myclabs/php-enum but this library is not install by the composer install command, indeed it's not present in the composer.json file.

All for our models should have the fields dateAdd and dateUpdated so we can keep track of modification and creation DB in our database.

The JS tests use the PHP command to create users.

It means that JS tests depends on PHP. It is also an issue for #23 .

It implies that the JS model should map entirely the DB entry.

Would that cause any issue?

• ApiBundle
• WebBundle
• DemoBundle