cooptilleuls / cooptilleulsmigrationbundle Goto Github PK

Our context:
We have a User that we want to soft delete

// Entity\User.php

/**
 * @ApiResource(...)
 *
 * @ORM\EntityListeners({"AppBundle\EntityListener\UserEntityListener"})
 * @Gedmo\SoftDeleteable(fieldName="deletedAt", timeAware=true)
 * @Transformer("AppBundle\Transformer\UserTransformer")
 */
class User implements UserInterface
{
   //...
}

Issue:
We use the Transformer, however our object does not pass through the delete() of our UserTransformer as it passed through the preRemove() of the UserEntityListener.

After research and testing, it seems that our object is under the class Proxies\__CG __\AppBundle\Entity\User. However, in this case when passing through the getTransformerAnnotation() function of the TransformerEventListener, the @Transformer annotation is not found by reflection. And thus hasTransformer() return false, and in preRemove() the event is not triggered.

Proposed solution:
I solve this issue, but I have to edit your bundle, this way:

// TransformerEventListener.php

private function getTransformerAnnotation($object)
{
    $pattern = 'Proxies\\__CG__\\';
    if (0 === strpos(get_class($object), $pattern)) {
        $notProxiClassName = substr(get_class($object), strlen($pattern));
        $object = new $notProxiClassName;
    }
    return $this->reader->getClassAnnotation(new \ReflectionClass($object), Transformer::class);
}

For you, is it really an issue to fix from your side, or would it be up to me to make sure not to have a class Proxies\__CG__\... ?

Thank you, and do not hesitate to ask for more information

It's impossible to use autowiring with parent keyword:

services:
    App\Loader\UserLoader:
        class: App\Loader\UserLoader
        parent: coop_tilleuls_migration.loader.abstract
        autowire: false
        autoconfigure: false
        public: false
        tags:
            - { name: coop_tilleuls_migration.loader, alias: user }

• Fix CI
• Update to Symfony 5.1

Supports Symfony 3.3
Remove alias on tag declaration (improvement for autowiring)

With a default configuration, to prevent having this error during install:

The child node "legacy_connection_name" at path "coop_tilleuls_migration" must be configured.

• Use vendor/bin/simple-phpunit instead of phpunit/phpunit
• Use shivammathur/setup-php