Giter VIP home page Giter VIP logo

coreui-pro's People

Contributors

andresgalante avatar bardiharborow avatar coliff avatar cvrebert avatar dependabot-preview[bot] avatar dependabot[bot] avatar fat avatar ffoodd avatar geosot avatar gijsbotje avatar glebm avatar hnrch02 avatar johann-s avatar julien-deramond avatar juthilo avatar kkirsche avatar martijncuppens avatar mdo avatar mrholek avatar pat270 avatar patrickhlauke avatar pvdlg avatar rohit2sharma95 avatar stevenblack avatar twbs-grunt avatar vsn4ik avatar xhmikosr avatar ysds avatar zalog avatar zlatanvasovic avatar

Stargazers

avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

curry684 ksbecker nocnp l3akage classicvalues limweb g3n3s1sl4b safety-mates-australia

coreui-pro's Issues

Accordion dark theme CSS variable name for button mismatched

In .accordion.scss

.accordion {
  // scss-docs-start accordion-css-vars
 ...
  --#{$prefix}accordion-btn-padding-x: #{$accordion-button-padding-x};
  --#{$prefix}accordion-btn-padding-y: #{$accordion-button-padding-y};
  --#{$prefix}accordion-btn-color: #{$accordion-button-color};
  --#{$prefix}accordion-btn-bg: #{$accordion-button-bg};
  --#{$prefix}accordion-btn-icon: #{escape-svg($accordion-button-icon)};
  --#{$prefix}accordion-btn-icon-width: #{$accordion-icon-width};
  --#{$prefix}accordion-btn-icon-transform: #{$accordion-icon-transform};
  --#{$prefix}accordion-btn-icon-transition: #{$accordion-icon-transition};
  --#{$prefix}accordion-btn-active-icon: #{escape-svg($accordion-button-active-icon)};
  --#{$prefix}accordion-btn-focus-border-color: #{$accordion-button-focus-border-color};
  --#{$prefix}accordion-btn-focus-box-shadow: #{$accordion-button-focus-box-shadow};
  ...
  --#{$prefix}accordion-active-color: #{$accordion-button-active-color};
  --#{$prefix}accordion-active-bg: #{$accordion-button-active-bg};
...
  // scss-docs-end accordion-css-vars
}

In dark theme (themes/dark/_variables.scss), the $accordion-theme-map use

"accordion-button-color":               $accordion-button-color-dt,
"accordion-button-bg":                  $accordion-button-bg-dt,
"accordion-button-active-bg":           $accordion-button-active-bg-dt,
"accordion-button-active-color":        $accordion-button-active-color-dt,
"accordion-button-focus-border-color":  $accordion-button-focus-border-color-dt,
"accordion-button-icon":                $accordion-button-icon-dt,
"accordion-button-active-icon":         $accordion-button-active-icon-dt

Resulting in :

image

"accordion-button-active-bg":           $accordion-button-active-bg-dt,
"accordion-button-active-color":        $accordion-button-active-color-dt,

also should be

"accordion-active-bg":           $accordion-button-active-bg-dt,
"accordion-active-color":        $accordion-button-active-color-dt,

Write Access -> Sry I've pushed to wrong repo

I'm sorry - I have write access and push to your repo and not to my local fork.

Please undo my changes (or better rebase)

Sorry again...

P.S.: The Hook on loadPage(url) in ajaxload.js could possibly a good idea to include in main repo (I use this to cleanup signalr/websockets connections on page change)

querySelectorAll('script[src]') is possibly a little bit more accurate than querySelectorAll('script'), without this inline scripts don't work.

Remove SASS deprecations

Description

Following the upgrade guide from SASS, functions declared in @coreui/coreui-pro/scss/_functions.scss should be changed to assure forward compatibility with future SASS versions.

This PR is also related to coreui/coreui#498

Package versions

  • @coreui/coreui-pro: 4.4.2
  • sass-loader: 13.2.0
  • sass: 1.56.2
  • webpack-cli: ^5.0.1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.