corgan2222 / extstats Goto Github PK

I found this repo by crawling through the web looking for SNMP support for the AX88U as I have 3 of them in my house. I'm impressed by the work that has been done, but I'm not sure if I want to install this onto all my routers.

Have you thought about rewriting this as a service that polls the same data through SSH? One benefit would be that you could easily make it a docker container with a config-file where you specify each routers IP and then you wouldn't have to maintain the code in multiple places. Also I think it would be cleaner as you wouldn't have to mess with the router except from enabling SSH on LAN. Any thoughts about it? I don't see any reason why that shouldn't work and will try to see if I can start working on it soon as a proof of concept.

I have tried with a influxdb in docker, on my local machine & influxdb cloud but unable to connect. No error when creating db but when I test I get this.
showing Databases q=SHOW DATABASES
{"code":"unauthorized","message":"Unauthorized"}
Insert Test Data in DB router_exstats
HTTP/1.1 401 Unauthorized
Content-Type: application/json; charset=utf-8
X-Influxdb-Build: OSS
X-Influxdb-Version: v2.7.1
X-Platform-Error-Code: unauthorized
Date: Sun, 18 Jun 2023 12:50:31 GMT
Content-Length: 48

{"code":"unauthorized","message":"Unauthorized"}
SHOW MEASUREMENTS from DB router_exstats
{"code":"unauthorized","message":"Unauthorized"}
SHOW SERIES from DB router_exstats
{"code":"unauthorized","message":"Unauthorized"}
Remove Test Database
{"code":"unauthorized","message":"Unauthorized"}

All you need is this:
cat /sys/class/thermal/thermal_zone0/temp | awk '{print $1 / 1000}'

Does this work with Merlin 388.1?

Hello!
Love your project!
I'm running on my old and unsupported RT-AC56 (348.5), and after fixing the python3 dependency it started and looks quite ok for my needs (basic health, traffic).

I'm ashamed to admit that I spent way too much time looking for the grafana template. There should be a node/link in the main README :)

Most things seem to be working - even traffic per client - with the exception that I get mac addresses as names instead of the DNS name for static leases. Not sure if that is fixable or not.

Hi,
I have Asus AC88U with MerlinWRT, do I need to install python on the router? because it is not installed.

Will be using this thread to tabulate some of the issues I have found. Great job in trying to put something like this together ( I had hacked getting node-exporter and some custom parsing in a text file, but this has a lot more info to it:

1. opkg currently does not have python available. Had to install python3.
2. pip also wasn't able to be installed, as the package is not python3-pip.
3. When running the traffic export (toggle traffic analyzyer stats) to influx, I get an issue with export.py has the wrong command line variables --verify-ssl is no longer available:

usage: export_py.py [-h] -i [INPUT] [-d [DELIMITER]] [-s [SERVER]] [--port [PORT]] [-u [USER]] [-p [PASSWORD]] --dbname [DBNAME] [--create] [-m [METRICNAME]] [-tc [TIMECOLUMN]]
                    [-tf [TIMEFORMAT]] [-tz TIMEZONE] [--fieldcolumns [FIELDCOLUMNS]] [--tagcolumns [TAGCOLUMNS]] [-g] [-ssl] [-noverify] [-b BATCHSIZE]
export_py.py: error: unrecognized arguments: --verify_ssl

I updated the code in mod_trafficAnalyzer.sh

if [ "$EXTS_NOVERIFIY" = "true" ]; then
        SSL_VERIFY="--noverify"
fi

When the InfluxDB configuration related to ping-auth-enabled is true the script cannot ping the database.

Ref. InfluxDB config:

  # Enables authentication on the /ping, /metrics, and deprecated /status
  # endpoints. This setting has no effect if auth-enabled is set to false.
  ping-auth-enabled = true

Hi,
concerning the topic "how to get the CPU temperature" here is a way to do it on AX88u (here is a simplified Python function):

def getCpuTemp():
  f = open("/sys/class/thermal/thermal_zone0/temp")
  temp = f.read()
  f.close()
  return int(temp)/1000

Note: if you decide to implement it in Python you should add some error management to the above code depending on how you use it, e.g. in case the file is not there (in AX88u it should be always there, but on a different router it could be in another place or just be missing).

P.S.: I've seen other topics against the use of Python on the router due to higher resources usage, however the real point should not be to avoid the use of Python, but to try to avoid calling python scripts as you do with other binary executables in bash scripts (quote: “Don’t cross the streams.”).
Bash in itself is fast and light, however the burden starts to be heavy when you call multiple external executables in the script (even compiled binaries). Every single external script/command called involves, besides disk/cache access, allocating and running an additional process, if in a script you call many times external programs to perform small tasks the overhead is significant and it would probably be much more effective and efficient to run everything in a single Python (even better from byte-code) or Perl script.
To sum up:

• Bash is fast and efficient al long as it doesn't run a lot of external commands (but its native functions are very limited so thus you need rely heavily on externals).
• Perl is very fast in parsing files, but if you need to use additional perl libraries this would make more difficult to manage the dependencies on the router and it even might become significantly more resource intensive.
• Python is fast and has a good number of native functions plus with the ability to run byte code so it's in game with the Perl scenario.

So if you can do it with native bash involving a very limited number of external commands in it, go for it. If you need a lot of external commands I'd say to consider Perl, which is very fast in parsing text and files. If you need Perl libraries I'd say to give it a shot with Python and its native features. Mostly the decision depends on how complex are the scripts and the hardware on which they will run.