corsc / go-tools Goto Github PK

If you supplied the -i flag without a value the error message does not make any sense

2017/03/03 00:40:50 error file finding coverage files chdir 70: no such file or directory Error: error file finding coverage files chdir 70: no such file or directory

General idea here is to use this tool to "fail builds" when coverage drops below set minimums.

Something like:

package-coverage -c -min 70

// Outputs:
Fail: github.com/corsc/go-tools/ is 50.1% (minimum: 70.0%)

package-coverage -c -p ./ works as intended

package-coverage -c -p ./some-package/ does not. The coverage is generated but nothing is printed
package-coverage -p ./my-package/ however does work as intended

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x1195f70]

such as if your interface like this
type test interface { MyTest() }

the error code is
`
func extractParamsAndResults(fnDesl *ast.FuncType) ([]MethodField, []MethodField) {
params := extractFieldsFromAst(fnDesl.Params.List)
results := extractFieldsFromAst(fnDesl.Results.List)

return params, results

}
`

you should change it like this
`
func extractParamsAndResults(fnDesl *ast.FuncType) ([]MethodField, []MethodField) {
var params []MethodField
var results []MethodField
if fnDesl.Params.List != nil {
params = extractFieldsFromAst(fnDesl.Params.List)
}

if fnDesl.Results.List != nil {
	results = extractFieldsFromAst(fnDesl.Results.List)
}

return params, results

}
`