Giter VIP home page Giter VIP logo

Comments (5)

cotes2020 avatar cotes2020 commented on May 26, 2024 1

The situation is a bit awkward, this feature requires a file giscus.json to be created in the repo root directory.

Currently I have no way to decide whether to generate this file based on the site config. If a user doesn't use giscus, then his/her repository will have a useless giscus.json.

Perhaps you can create this file in your own repo and configure it as needed.

from jekyll-theme-chirpy.

timothystewart6 avatar timothystewart6 commented on May 26, 2024

I see. Couldn't you just generate the file if the key giscus.repo is defined in _config.yml? Otherwise I agree, I can just create a giscuss.json

from jekyll-theme-chirpy.

timothystewart6 avatar timothystewart6 commented on May 26, 2024

Ah, nevermind. This would always be undefined when the site is generated.

from jekyll-theme-chirpy.

cotes2020 avatar cotes2020 commented on May 26, 2024

I see. Couldn't you just generate the file if the key giscus.repo is defined in _config.yml? Otherwise I agree, I can just create a giscuss.json

To the best of my knowledge, this is not achievable, as expressed in my comment above.

from jekyll-theme-chirpy.

timothystewart6 avatar timothystewart6 commented on May 26, 2024

I will close it then, I totally understand why this would be confusing for some and there is a workaround if using giscus.

from jekyll-theme-chirpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.