Giter VIP home page Giter VIP logo

Comments (5)

cotes2020 avatar cotes2020 commented on September 26, 2024

Sorry, I don't understand what the "switching image" is, could you please provide a screenshot to illustrate the problem?

from jekyll-theme-chirpy.

kungfux avatar kungfux commented on September 26, 2024

If I understand correctly, the issue is about glightbox and the ability to view all images by "switching" to the next/previous image in the gallery.

Here is a live example https://chirpy.cotes.page/posts/text-and-typography/#darklight-mode--shadow. The post contains images created specifically for light and dark themes. If you open an image and toggle to next/previous, you will see an image not for the current theme in the gallery.

from jekyll-theme-chirpy.

huanyushi avatar huanyushi commented on September 26, 2024

Yes, what @kungfux said was exactly what I wanted to feedback on.

If you click an image on https://chirpy.cotes.page/posts/text-and-typography/#darklight-mode--shadow, you can see the next button,

image

If you click the button it will switch to the next image and you will see all images (regardless of whether they are for the light or dark mode).

from jekyll-theme-chirpy.

cotes2020 avatar cotes2020 commented on September 26, 2024

I'm just keeping Glightbox's default behavior, to hide images that don't fit the theme mode, you may need to modify Glightbox configuration, or have Glightbox disable looping images, and just use its zoom.

Either way, you're welcome to submit a PR to help improve this!

from jekyll-theme-chirpy.

github-actions avatar github-actions commented on September 26, 2024

This conversation has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from jekyll-theme-chirpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.