cougargrades / api Goto Github PK

it's getting a little nasty

related to #8

In sample data see Banks, Lori D

When a document in upload_queue fails to process, move it to upload_queue_backlog instead of leaving it in upload_queue.

This upload_queue_backlog can be processed by:

• A scheduled job that runs once a day which copies all of the backlog into upload_queue for reprocessing.
• Add a hidden property like __backlogCount which prevents infinite loops

Patchfile "merge" operations happen when no document exists. "merge" operations should silently fail if the document at the specific location doesn't exist.

I believe this is because of an oversight in the implementation made here: cougargrades/importer@8d5cb57

Here, the rows which contain no data (when parsing the CSV, an empty string '') are replaced with zero, which in turns brings the average down among other statistics.

https://github.com/cougargrades/importer/blob/8d5cb57462d82ba02233dd75975ab6f8306305e8/src/reader.ts#L60-L66

A comprehensive fix will require updating the importer, types, and api codebases to explicitly support null values instead of undefined values.

This would save a lot of time and replace the need for the 2nd phase of Patchfiles.

Perhaps some default groups could be entirely implemented in the API instead.

https://github.com/cougargrades/publicdata/blob/fd639a7e0abf310690cfa2b0472cf13034f5fa48/bundler/bundle/patch/subjects.py#L43-L60

Will be necessary for the @cougargrades/importer rewrite.

With Firebase auth being researched, users should have more granular permissions, similar to the behavior of "Tokens"

Notes:

• https://stackoverflow.com/q/46835481

Version in use as of posting: 0.0.42

Version 0.0.43 changes:

• Removed Courses.publication
• Added Courses.publications[]

Version 0.0.44 changes:

• Added Instructor.firstTaught
• Added Instructor.lastTaught

Version 0.0.45-0.0.47 changes:

• firestore.FieldValue support

Probably based on:

https://github.com/cougargrades/web/blob/afc56a8697327e46d07749cab05a528727ec93d7/.github/workflows/firebase.yml

notably for having read and write permissions if admin claim is true