Use namespace for helpers usage:

import { * as konnectors } from './helpers/konnectors
konnectors.isTwoFAError(...)

instead of

import { isKonnectorTwoFAError } from './helpers/konnectors
isKonnectorTwoFAError(...)

Connection error translations have moved from cozy-home to
cozy-harvest-lib. But we haven't backported translated files
from transifex/cozy-home to transifex/cozy-harvest-lib.

Below is an archive of the locales of cozy-home on the 15/01/2019
before cleaning up of the cozy-home locales was done. This should
enable us to send those locales inside harvest.

cozy-home-locales-15-01-2019.zip

We should also think of removing the deprecated connection.error slice
from cozy-home's locales. A potential problem would be that an older
cozy-home version would not find old locales on transifex. This is why I think
we should not integrate locales at build time but periodically download
them and commit them to the repo, so that

• the old version not finding old locales problem would be solved (since it would
  take the locales from its repo)
• an application can be built without talking to Transifex
• more reproducible build

In the store, apps are probably rank by ASCII order, and the result is a bit suprising for the user.
For example 'HSBC' is before 'Hello bank'.

The real alphabetical order would be better if possible.

Thank's

What is the difference between an datatype and a doctype ? Are they the same ?

In Collect, we are considering that every konnector use a couple of fields login/password to gather user credentials for external services.

But it is not always the case, some konnectors are configured to expect a identifier or an email in place of a login. However, the most part of the konnectors are using login/password. As we expect to deal with more and more konnectors in the future, the case will happen when a konnecor will use a totally unexpected name for the login field, let's say for example userKey.

The code actually deals with only three possibilities, login, email, and identifier. We cannot expect to deal with every new login field name which will pop up in the future.

Using a role attribute in manifest

A solution could be to use a role attribute for a field. Those role coule be login or password. May be the list of possible value may evolve in the future. This role coule be precised in the manifest.konnector:

"fields": {
	"identifier": {
    	"role": "login",
		"type": "text"
  	},
  	"secret": {
		"role": "password",
		"type": "password"
	}
}

Legacy

To maintain legacy and avoid updating all konnectors manifests, we should keep the login and password identifier as reserved default ones. So we could use helpers like:

const isLogin = field => [field.name, field.role].includes('login')
const isPassword = field => [field.name, field.role].includes('password')

TL:DR;

• Use default login and password field for credentials
• Add login and password role attribute for credential fields with a different name

This solution seems pretty simple and future-proof but experience showed us that in Collect and konnectors some technical choices can have heavy consequences. Do you see a flaw on this solution?

Since the migration of the my account application to v3, a connector is installed when selecting it (if needed). At the moment, an "Installing" string is displayed.

It would be better to use a standard loading widget for that.

Here is the file where the Installing screen is displayed : https://github.com/cozy/cozy-my-accounts/blob/master/app/containers/ConnectorManagement.jsx#L83

Scenario

1. I connected an account throught cozy collect
2. I waited for the completion of the konnector
3. I tried to close the konnector modal and it won't close :

Uncaught (in promise) TypeError: Cannot read property 'focus' of null
    at t.value (app.js:formatted:18132)
    at g (app.js:formatted:7148)
    at T (app.js:formatted:7339)
    at O (app.js:formatted:7284)
    at T (app.js:formatted:7306)
    at O (app.js:formatted:7284)
    at T (app.js:formatted:7306)
    at u (app.js:formatted:7077)

The line of the error:

        c(t, [{
            key: "componentDidMount",
            value: function() {
                this.props.giveFocus && h.default.findDOMNode(this).querySelector("input").focus()
            }
        }, {

Doc: https://github.com/cozy/cozy-collect/blob/master/docs/connector-configuration.md
Config: https://github.com/cozy/cozy-collect/blob/master/src/config/konnectors.json

I do not understand :

• what the empty list in the accounts property does.
• what is the dataType property for
• what are the allowed categories (I went to https://github.com/cozy/cozy-collect/blob/6d6a98bd2fc7e4a15293a5ef9fe399efc7f97697/src/locales/en.json to check them)

I discovered the useAppDataset hooks and I wonder if a hook was really necessary. It seems that for every component using this hook, we will have two renders (initial render + after the setState) where only one was necessary. Subsequent renders will not trigger a DOM access but still, it makes two render instead of one.

I wonder if the dataset access method should not be directly in CozyClient ? This way at app start, we init from the dataset div and then we can access values directly via CozyClient without a second render.

More context in the PR : #1391 (comment)

As described by one of our users, a connector does not work because it declares a field of type tel:

"fields": {
    "login": {
        "type": "tel"
    },
    "password": {
        "type": "password"
    }
}

https://github.com/konnectors/digitick/blob/23a92158ff9abfa06f2c67311534b937c8d76ce4/manifest.konnector#L14

The documentation and the codebase are saying the same: the type must be one of dropdown, email, hidden, password, text, checkbox.

I open this issue to ask to add a type tel: it is as useful as a type email. Otherwise type text would be enough.

update UI from beta2 to beta19

• beta2 uses the old modal $dialog -> use the React component modal instead
• trash base/_colors.styl and base/_normalize.styl & adapt color variables (embedded with Cozy-UI)
• remove base-font-size = 16 it's in Cozy-UI
• Divide & conquer. Not everything in one only file
• Review the application's DOM so it fits Cozy-UI's layout needs (See Drive app's DOM for an example)
• Re-use UI styles for form elements & buttons
• Use the Notifier React component from Cozy-UI

⚠️ This is just a draft of what I saw, this is not an exhaustive list.

Linxo has a similar file as src/config/konnector.js where they describe all the banks they connect to and what credentials each bank needs.

For each fields, they have a validation in the form of a regexp. It might be something to consider to provide validation for our fields.

Example:

      {
        "id": "86",
        "label": "Identifiant",
        "type": "TextField",
        "regexp": "[0-9]+"
      }

As described here #58 (comment)

In the connector config file, we declare a konnector as this:

[
  {
    "oauth": true,
    "slug": "maif",
    "name": "MAIF",
    "editor": "Cozy Cloud",
    "vendorLink": "maif.fr",
    "testing": true,
    "categories": ["insurance"],
    "fields": {
      "access_token": {
        "type": "hidden"
      }
    },
    "dataType": ["profile", "contract", "home", "family", "sinister"],
    "source": "git://github.com/konnectors/cozy-konnector-maif.git#latest",
    "oauth_scope": "openid+profile+offline_access"
  }
]

If you don't want the konncetor to be shipped (for test purposes), you need to add a property "testing": true. But if your forget to add this property, then it will be shipped and could break the cozy-stack database by creating inconsistent data.

"testing": true should be the default value, then errors can not be made as we have to declare "testing": false or "prod": true if we do want the connector to go into production.

cozy-collect instead of Cozy Collect.

Screenshot from fab.

If you use cozy-scripts the problem should be fixed by https://github.com/CPatchane/create-cozy-app/pull/627

Hi,
My self-hosted instance uses the nested subdomains scheme (mon.cozy.chez.moi), which is defined in the /etc/cozy/cozy.yml.local file:

[...]
subdomains: nested
[...]

But when I try to install a suggested konnector from the home App by clicking on a tile, the generated link uses the flat scheme (mon-cozy.chez.moi/#/discover/slug), leading to TLS certificate error.

I noticed that the current code seems to retrieve the instance subdomain scheme to build the correct URL, so it might be an issue in my server configuration.

Any idea on how to fix it? Is it a misconfiguration on my side or a real issue?

N.B.: I have the same issue when I try to access the retrieved documents of a connected Konnector from the Home app.

Caused by https://github.com/cozy/cozy-collect/blob/11f0680fac796785cb66d7f274fa59ada5ffa889/src/styles/services.styl#L69

Why not let overflow: auto do its job in this case ?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

• WARN: Using npm packages for Renovate presets is now deprecated. Please migrate to repository-based presets instead.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• fix(deps): update dependency cozy-client to ^48.1.1
• fix(deps): update dependency cozy-harvest-lib to ^26.0.3
• fix(deps): update dependency cozy-sharing to ^15.0.1
• fix(deps): update dependency redux to v4.2.1
• fix(deps): update dependency terser-webpack-plugin to v1.4.5
• fix(deps): update dependency @types/classnames to v2.3.1
• fix(deps): update dependency babel-preset-cozy-app to v2.1.0
• fix(deps): update dependency bundlemon to v1.4.0
• fix(deps): update dependency date-fns to v2.30.0
• fix(deps): update dependency es-abstract to v1.23.3
• fix(deps): update dependency eslint to v8.57.0
• fix(deps): update dependency eslint-config-cozy-app to v4.2.1
• fix(deps): update dependency leaflet to v1.9.4
• fix(deps): update dependency moment to v2.30.1
• fix(deps): update dependency node to v20.14.0
• fix(deps): update dependency papaparse to v5.4.1
• fix(deps): update dependency react-router-dom to v6.23.1
• fix(deps): update dependency redux-thunk to v2.4.2
• fix(deps): update dependency stylus to v0.63.0
• fix(deps): update dependency url-search-params-polyfill to v8.2.5
• fix(deps): update react monorepo (@types/react, @types/react-dom, react, react-dom, react-test-renderer)
• fix(deps): update testing-library monorepo (@testing-library/jest-dom, @testing-library/react)
• fix(deps): update actions/checkout action to v4
• fix(deps): update dependency bundlemon to v2
• fix(deps): update dependency date-fns to v3
• fix(deps): update dependency eslint to v9
• fix(deps): update dependency eslint-config-cozy-app to v6
• fix(deps): update dependency form-data to v4
• fix(deps): update dependency husky to v9
• fix(deps): update dependency lint-staged to v15
• fix(deps): update dependency react-inspector to v6
• fix(deps): update dependency react-redux to v9
• fix(deps): update dependency redux to v5
• fix(deps): update dependency redux-thunk to v3
• fix(deps): update dependency remark-preset-lint-recommended to v7
• fix(deps): update dependency reselect to v5
• fix(deps): update dependency terser-webpack-plugin to v5
• fix(deps): update github/codeql-action action to v3
• fix(deps): update jest monorepo to v29 (major) (babel-jest, jest, jest-environment-jsdom)
• fix(deps): update testing-library monorepo (major) (@testing-library/jest-dom, @testing-library/react)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): replace dependency npm-run-all with npm-run-all2 5.0.0
• fix(deps): pin dependencies (eslint-import-resolver-alias, eslint-plugin-import, eslint-plugin-import-alias, localforage, node, prop-types, react-hot-loader, react-remove-scroll, redux-persist, reselect)
• fix(deps): update dependency react-redux to v7.2.9
• fix(deps): update dependency cozy-doctypes to v1.91.0
• fix(deps): update dependency cozy-intent to ^2.22.0
• fix(deps): update dependency cozy-scripts to v8.3.0
• fix(deps): update dependency cozy-device-helper to v3
• fix(deps): update dependency cozy-realtime to v5
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Those lines https://github.com/cozy/cozy-collect/blob/71fe4fa900fa91d0e3051bec9cf18ab7eb9c36b2/src/styles/accountConnection.styl#L3-L16 are way too generic and mess with elements in the cozy-bar, losing its integrity across apps.

You should… narrow a little more the selector with a class from Collect only, I guess.

https://github.com/cozy/cozy-data-connect/blob/master/src/lib/accounts.js

Only login and password are passed further on. My connector expects an email field and it disappeared during the account creation.

I am accustomed to typing my username, password and hitting Enter to submit a form. It does not work there.

Add connectors for Property ads to rent/buy a flat or house, by connecting to sites such as seLoger.com, leboncoin.fr, pap.fr, bienici.fr, and so on. If a user connects its cozy cloud to its personal profiles on these sites, he/she would be able to visualize in one single place all the ads, and compare their properties - surface, cost, room count, localisation. Of course, it would require a new ui app to sort these ads out, and a custom doctype is also important.

[edit] : was added as a request in the providers page. A discussion could be interesting to do though to gather ideas around how to proceed - where to start given https://docs.cozy.io/en/dev/konnector/ and how to parse the ads elements and produce a good use case for cozy cloud - not yet existing way to gather these information from different profiles.

The home should migrate to React as soon as possible to diminish the number of hard to resolve bugs due to lack of compatibility between React and Preact.

It seems one of the task that could be done step by step would be the removal of direct context usage, which does not work with React (cannot access the context as easily as in Preact). After those replacements, it will be easier to switch to React.

To replace direct context usage:

• components using context.t, context.f are wrapped in translate() and props.t/props.f can be used used
• for client/domain, withClient can be used
• context.router via withRouter
• For context.store a custom HOC could be used.

Below are the instances of direct context usage:

test/jestLib/I18n.js
13:export const tMock = context.t
15:export const fMock = context.f

src/components/AppTile.jsx
10:    const { domain, secure } = this.context

src/components/TriggerFolderLink.jsx
29:    const { client } = this.context

src/components/KonnectorTile.jsx
71:    const { domain, features, secure } = this.context

src/lib/statefulForm.jsx
25:        const { t } = context
215:        const { t } = this.context

src/components/KonnectorHeaderIcon.jsx
10:    const { domain, secure } = this.context

src/components/KonnectorSuccess.jsx
129:      return <BanksLink key={i} banksUrl={context.store.banksUrl} />

src/store/configureStore.js
10:const configureStore = (client, context, options = {}) => {

src/containers/IntentHandler.jsx
12:    this.store = context.store
63:    const { t } = this.context

src/containers/ConnectionManagement.jsx
34:    this.store = this.context.store
36:    const { t } = this.context
188:    const { t } = this.context
207:      const { router } = this.context

src/containers/IntentService.jsx
40:    const { t } = this.context

src/containers/AccountConnection.jsx
30:    this.store = this.context.store
205:    const { t } = this.context

src/containers/App.jsx
31:    this.store = this.context.store

src/lib/redux-cozy-client/connect.jsx
14:      const dispatch = this.context.store.dispatch
21:      const { t, f, client, store } = this.context

src/components/intents/CreateAccountIntent.jsx
9:    this.store = this.context.store

src/ducks/connections/components/queue/queue.jsx
52:    const { domain, secure } = this.context

I am working on the banking connectors. Linxo's API has a listFinancialInstitutions route which list all the banks along with their logos etc... I will rely on this data to generate the config to copy/paste in config/konnectors.json. Some images for the logo are not in SVG. Can we support other formats : png, jpg, gif ?

This would make the grid more readable and easier to modify.

Large screen

Small screen

Since the Home is not listed in the Store, we don't display its permissions for now so we don't have the permissions' list in our translation files.

Even if the app has a specific behavior, we should try to keep as close as possible to our global behavior aka, we should write the permissions in our translations files

(see #1503 (comment) for more context)

Je viens de faire une PR un peu crade pour faire un hotfix (#1478)

On s'attend à ce que installedKonnectors soit un array :

Sauf que installedKonnectors vient de getInstalledKonnectors https://github.com/cozy/cozy-home/blob/master/src/ducks/konnectors/index.js#L37 et que si j'ai pas de !!state.documents ça va retourner false.

Et du coup false.some ne fonctionne pas. Vu qu'on utilise getInstalledKonnectors à plusieurs endroits j'ai pas voulu corriger à la source pour pas faire un hotfix trop large

We're planning to migrate Collect's store to redux. First of all, I think we should agree about what the state should look like.

So there is my first proposition, let's discuss :

Entities

As specified in this presentation made by @goldoraf, we should keep a list of our entities.

The entities we need are : Konnectors, Konnector results, Accounts, Jobs.

{
  api: {
    endpoint: { ... },
    entities: {
      io.cozy.konnectors: { // installed konnectors },
      io.cozy.konnectors.result: {},
      io.cozy.accounts: {},
      io.cozy.jobs: {}
      }
    },
  },
  ...

If I undestood well, those entities are already managed by redux-cozy-client, so let's dive into the custom part.

Store

At startup, no konnector is installed and the konnector list comes from the file src/config/konnectors.json.

  ...,
  store: {
    konnectors: {
      ...
      maif: { ... }
      trainline: { ... }
      ...
    }
  }
  ...

Connections

We use connections to reflect the status of an account associated with a konnector. To determine this status we need at least the last konnectorResult for the given konnector, and a running job if it exists.

This part of the state will play a major role in Collect, and will be at the center of the realtime logic.

My first idea for this part is something like this. This example is multi-accounts ready !

  ...,
  connections: {
    konnectors: {
      trainline: {
        accounts: {
          '3214543345345345453': {
            status: 'connecting',
            folder: {
              status: 'created'
            },
            konnectorResult: {
              id: '8889987657564364',
              status: 'errored',
              error: {
                message: { 'LOGIN_FAILED' }
              }
            },
            job: {
              id: '556586856588658909009',
              status: 'running'
            }
          }
        }
      }  
    }
  }
  ...

UI

The UI part will consider all the konnectors filtered lists, the use-case and the opened modal. It should look like :

  ...,
  ui: {
    categories: {
      travel: {
        konnectors: [ 'trainline', ... ]
      }
    },
    usecases: [...],
    modal: {
      konnector: trainline
    }
  }
  ...

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

We have a new problem when publishing versions of the app : https://travis-ci.org/cozy/cozy-home/jobs/652921209#L1009

n error occured with postpublish hook mattermost: "mattermost" could not be loaded.
Publishing failed: Postpublish hooks failed: postpublish hooks failed

This is likely a problem with cozy-app-publish though.

Contains correct mapping for SCA_REQUIRED error from BI.

I have a connector that doesn't take any credentials, so I don't have any required fields on the login page :

The problem is that initially the submit button is disabled. If I type something in the optionnal field, it becomes enabled, even if I clear it afterwards :

https://github.com/cozy/cozy-collect/blob/master/docs/konnector-manifest.md should be moved to docs.cozy.io

SVG and PNG should be filled in white

Quand il n'y a pas de connecteurs connectés, l'écran est vide.

:'(

See the screenshot in cozy/cozy-ui#522

Following #1127

Hi,
When I go to the collect applications, I get the following error in French:
Quelque chose s’est mal passé pendant la récupération de vos connecteurs et de vos informations. Merci de recharger la page.

In the log, I see
time="2017-10-08T20:15:16+02:00" level=error msg="[http] GET /realtime/ websocket: not a websocket handshake: 'upgrade' token not found in 'Connection' header" domain=cozy.mytld

I moved to 1.02 version of collect andnow I have the same error as above plus:
time="2017-10-08T20:15:17+02:00" level=error msg="[http] GET /jobs/queue/konnector code=403, message=Forbidden" domain=cozy.mytld

I'm using an Apache proxy with the following config:

<VirtualHost *:443>
     ServerName cozy.levillain.fr.nf
     ServerAlias *.cozy.levillain.fr.nf
 
     SSLEngine on
     Header always set Strict-Transport-Security "max-age=31536000; includeSubDomains"
     SSLCertificateFile "/etc/letsencrypt/live/levillain.fr.nf/fullchain.pem"
     SSLCertificateKeyFile "/etc/letsencrypt/live/levillain.fr.nf/privkey.pem"
 
     ProxyPass / http://127.0.0.1:8080/
     ProxyPassReverse / cozy.levillain.fr.nf
#added this for websocket error 
    ProxyPass /realtime/ ws://127.0.0.1:8080/
# tried this, does not work
#   Header set Connection "upgrade"
#  RequestHeader set Connection "upgrade"                                                                                                  
     ProxyPreserveHost on
 
     ErrorLog ${APACHE_LOG_DIR}/cozy_error.log
     CustomLog ${APACHE_LOG_DIR}/cozy_access.log combined
 </VirtualHost>

I googled the error and found it's a websocket issue but neither adding myself the upgrade to the connexion header, nor using mod_proxy_wstunnel with a ProxyPass on /realtime/ to a ws url will work...

Dans konnectors/ovh#20 (comment)
Je relevais :

On devrait lire Tout s'est bien passé

When deleting an account from the home, I see requests to /triggers/undefined being sent.

The trigger is removed at the end so I guess that in the process, one of the request is successful (so it seems not critical).

7:26:33Z" level=debug msg="request: GET [REDACTED]%2Fio-cozy-triggers/undefined " domain=pbrowne.mycozy.cloud nspace=couchdb
7:26:33Z" level=debug msg="CouchDB(not_found): missing" domin=[REDACTED].mycozy.cloud nspace=couchdb

When adding a connector through the inter-app flow, I got an error. This error was caused because cozy-data-connect was added with the name cozy-data-connect instead of data-connect

http://cozy.tools:8080/konnectors/edf?Source=git%3A%2F%2Fgitlab.cozycloud.cc%2Fptbrowne%2Fconnecteur-edf.git

The error message should include as much information as possible for the developer to have an idea of what is going on.

When selecting a konnector to display, the command store.fetchOrInstallConnector is run.

If the command fails, the returned promise is rejected but no error is displayed on screen at the moment. A proper error notification should be displayed by changing the state of the connector and displaying a notification according to this new state in https://github.com/cozy/cozy-my-accounts/blob/master/app/containers/ConnectorManagement.jsx

As we can see here:

A lot of these items are using h3 or span elements. It would be beneficial to refactor these items to be <Typography /> elements. To go above that, it is suggested to even create an <ItemTitle /> component that would compose <Typography />.

As noticed in #271, to know which dataType we may use for the konnectors attribute dataType, we can only look at the locale file or open https://github.com/cozy/cozy-collect/tree/master/src/assets/sprites