cpraveen / dflo Goto Github PK

With gravity, potential can be computed and stored as an FE vector rather than recompute every time. update_q_points can then be removed from cell assembly.

We dont need shape values for cell assembly.

The include path in source files are not correct. So the CMake generated make file will not work.
For example, inside src/assemble_explicit.cc, the include statement reads

#include <base/quadrature_lib.h>

which should be

#include <deal.II/base/quadrature_lib.h>

I tested with the naca0012 mesh but found the solution not satisfactory. Is it because this code can not apply to non-cartesian mesh yet ? If I want to add this feature, which part of the code should I modify?

With Gauss nodes for basis functions, mass matrix is diagonal but we use full matrix which is computationally inefficient. Exploit the diagonal structure of the mass matrix to speed-up computations.

For TVD limiter, we need cell average of neighbouring cells. If they are at different levels, then we have to compute cell average carefully. If neighbour cell is coarser, then compute cell average by integrating on subcell.

Currently we assume square/cubic cells.

Since we use QGauss nodal basis, we can optimize this function. No need to call get_function_values.

If cell is adjacent to slip boundary, then ghost cell state must be used to compute backward/forward difference in the limiter.

Some parts of code like limiter, numerical flux (some of them), etc. are written only for 2-d case.

Hello,

when running dflo (built against deal.ii >=8.3) from src_mpi, and after fixing external_force function parser initialization, I get a runtime error:

An error occurred in line <4373> of file </home/pkestene/local/dealii_4_dflo/include/deal.II/fe/fe_values.h> in function
const std::vectordealii::Point& dealii::FEValuesBase<dim, spacedim>::get_quadrature_points() const [with int dim = 2; int spacedim = 2]
The violated condition was:
this->update_flags & update_quadrature_points
The name and call sequence of the exception was:
ExcAccessToUninitializedField("update_quadrature_points")
Additional Information:
You are requesting information from an FEValues/FEFaceValues/FESubfaceValues object for which this kind of information has not been computed. What information these objects compute is determined by the update_* flags you pass to the constructor. Here, the operation you are attempting requires the <update_quadrature_points> flag to be set, but it was apparently not specified upon construction.

Following what is done in src, if I add the requested flag, everything seems OK.
I'll place a pull request for that. Please ignore if you can fix this otherwise.

best regards,
Pierre Kestener.