Giter VIP home page Giter VIP logo

nordic-dfu-fork-issue-repo's Introduction

react-native-nordic-dfu Salt-PepperEngineering fork test

There are branches with multiple cases to try, to test follow instructions on each one

Cases differ in AndroidManifest.xml setups

my-case

This is the case I encountered in my project

  • if already installed, uninstall app from device
  • run git checkout main
  • run yarn
  • run git checkout 9b9aaf1
  • install app on Android 12 device npx react-native run-android
  • Allow location permission
  • Start bluetooth scan to test implementation - it should be fine
  • run git checkout ea485d4
  • run yarn, forked version will be installed
  • install app on Android 12 device npx react-native run-android
  • Start bluetooth scan to test implementation - it fails

In this case I think it should not be failing, because I did not do anything other then installing the forked version. Reverting to original package won't fix this issue, we now must be handling the BLUETOOTH_SCAN permission.

current-docs-case

Here I followed setup from current docs

  • if already installed, uninstall app from device
  • run git checkout main
  • run yarn
  • run git checkout c0118e9
  • install app on Android 12 device npx react-native run-android
  • Allow location permission
  • Start bluetooth scan to test implementation - it fails

Here it already fails with the non forked version, it's because the BLUETOOTH permissions are limited to SDK 30 and we should be also handling BLUETOOTH_SCAN permissions in the app.

suggestion-case

Initial setup according to Pilloxa/react-native-nordic-dfu#169 (comment)

  • if already installed, uninstall app from device
  • run git checkout main
  • run yarn
  • run git checkout 0270d74
  • install app on Android 12 device npx react-native run-android
  • Allow location permission
  • Start bluetooth scan to test implementation - it fails

Same reason as current-docs-case

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.