craftacademylabs / cypress-metamask Goto Github PK

View Code? Open in Web Editor NEW

44.0 44.0 26.0 883 KB

License: MIT License

Shell 0.72% JavaScript 94.98% HTML 4.30%

cypress-metamask's People

Stargazers

Watchers

Forkers

chamsbouzaiene withtally eenagy chiragbhaijifsd ismailcodes ksolo gitcoinco jmagder ensdomains latteswap-official lipsa16qe makerdao-dux avp1598 rjoshi-deq an-haijun markotf

cypress-metamask's Issues

Switching to Custom Network - Fails if config is the same as default Localhost

Description

If you set environment variables (NETWORK_NAME, RPC_URL, and CHAIN_ID) the code follows the logic to create a custom network (

cypress-metamask/support/metamask.js

Lines 267 to 295 in 2da7a1c

 async initialSetup({ secretWords, network, password }) { 

 const isCustomNetwork = 

 process.env.NETWORK_NAME && process.env.RPC_URL && process.env.CHAIN_ID; 

 await puppeteer.init(); 

 await puppeteer.assignWindows(); 

 await puppeteer.metamaskWindow().waitForTimeout(1000); 

 await puppeteer.metamaskWindow().bringToFront() 

 if ( 

 (await puppeteer.metamaskWindow().$(unlockPageElements.unlockPage)) === 

 null 

 ) { 

 await module.exports.confirmWelcomePage(); 

 await module.exports.importWallet(secretWords, password); 

 if (isCustomNetwork) { 

 await module.exports.addNetwork(network); 

 } else { 

 await module.exports.changeNetwork(network); 

 } 

 walletAddress = await module.exports.getWalletAddress(); 

 await puppeteer.switchToCypressWindow(); 

 return true; 

 } else { 

 await module.exports.unlock(password); 

 walletAddress = await module.exports.getWalletAddress(); 

 await puppeteer.switchToCypressWindow(); 

 return true; 

 } 

 },

). When these parameters are the same as the localhost configuration already set up with MetaMask installations the creation of the customer network fails silently, which causes the setup to hang since it is waiting for the network name to appear as an option (

cypress-metamask/support/metamask.js

Lines 203 to 206 in 2da7a1c

 await puppeteer.waitForText( 

 mainPageElements.networkSwitcher.networkName, 

 network.networkName, 

 );

If you are wanting localhost (which was my case) I unset the RPC_URL and CHAIN_ID and this worked as expected.

Thoughts/Suggestions

The localhost network configuration in Metamask assumes localhost:8545 with chain id 1337. If the provided RPC URL uses 0.0.0.0, localhost, or 127.0.0.1 with the port 8545 with the same chain_id the setup of the custom network will fail. If these match it should not attempt to add a custom network and instead update the network to use localhost instead.

function switchToCypressWindow() can't not use after initialSetup function done.

When I call function setupMetamask() in this function call initialSetup() after browser create custom network window can't not switch to main window. Last week it's work but not it's can't work.

Cannot read property 'bringToFront' of undefined

Details of the issue: Basically, the functionality of switching between the main cypress window and the metamask window fails way too often. When it happens, I get nice results like this:

So, the question is: Can we have a better way to detect displayed window and switch accordingly?

Thanks in advance for your help!

Typescript support

Thanks for the good work!

As a feature request, is it possible that this library adds a type definition (augmentation) of the custom methods added to cypress to use this library into an e2e cypress setup built with typescript?

Thanks in advance for helping me out with this!

"cy:open": "CYPRESS_REMOTE_DEBUGGING_PORT=9222 cypress open" doesn't work

When running the tests using the following command I am getting an error:
"cy:open": "CYPRESS_REMOTE_DEBUGGING_PORT=9222 cypress open"
Error:
'CYPRESS_REMOTE_DEBUGGING_PORT' is not recognized as an internal or external command, operable program or batch file.

I am unsure how to fix this.

Cannot read property 'waitForTimeout' of undefined

I followed the steps in the readme and set up my env with Kovan network. But i get this error on the cy.setupMetamask();

cy.setupMetamask is not a function

I am trying to run the Example but getting this error. Any help would be helpfull

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

	async initialSetup({ secretWords, network, password }) {
	const isCustomNetwork =
	process.env.NETWORK_NAME && process.env.RPC_URL && process.env.CHAIN_ID;

	await puppeteer.init();
	await puppeteer.assignWindows();
	await puppeteer.metamaskWindow().waitForTimeout(1000);
	await puppeteer.metamaskWindow().bringToFront()
	if (
	(await puppeteer.metamaskWindow().$(unlockPageElements.unlockPage)) ===
	null
	) {
	await module.exports.confirmWelcomePage();
	await module.exports.importWallet(secretWords, password);
	if (isCustomNetwork) {
	await module.exports.addNetwork(network);
	} else {
	await module.exports.changeNetwork(network);
	}
	walletAddress = await module.exports.getWalletAddress();
	await puppeteer.switchToCypressWindow();
	return true;
	} else {
	await module.exports.unlock(password);
	walletAddress = await module.exports.getWalletAddress();
	await puppeteer.switchToCypressWindow();
	return true;
	}
	},

	await puppeteer.waitForText(
	mainPageElements.networkSwitcher.networkName,
	network.networkName,
	);