Giter VIP home page Giter VIP logo

Comments (13)

brandonkelly avatar brandonkelly commented on May 28, 2024 5

Going to look into it soon.

from ckeditor.

pghorpade avatar pghorpade commented on May 28, 2024 4

Any update on this issue?

from ckeditor.

brandonkelly avatar brandonkelly commented on May 28, 2024 3

Just released v1.2.0, which adds support for CKEditor 4’s file manager integration.*

The update requires Craft 3.7.31 (just released today), so you will need to update Craft CMS before it becomes available.

If your field is using custom initialization code, you will need to add filebrowserBrowseUrl and filebrowserImageBrowseUrl to the editor config (which are predefined constants):

return CKEDITOR.replace('__EDITOR__', {
    language,
    filebrowserBrowseUrl,
    filebrowserImageBrowseUrl,
    // ...
});

Then you will find new “Browse Server” buttons within the image and link dialogs:

The CKEditor image dialog, with a red outline around the “Browse Server” button.

Pressing it will open up an asset selector UI in a popup window, which works just like asset selection modals within Redactor fields:

An asset selection popup window

Within the field settings, you can fine-tune which volumes should be visible, whether the user can see volumes/files they aren’t typically permitted to, and which image transforms should be available (and which should be selected by default).


*Unfortunately CKEditor 5 doesn’t have a similar easy way of integrating a file manager, so this is limited to CKE 4 for now.

from ckeditor.

theskyfloor avatar theskyfloor commented on May 28, 2024

This is coming in a future update to the plug-in. The Craft team hadn't implemented it yet because CKEditor was not stable. Now that it is they should be working on it. Although it would be great to get an idea of a timeline from them!

from ckeditor.

theskyfloor avatar theskyfloor commented on May 28, 2024

This is going to be coming and integrated now? : )

from ckeditor.

proimage avatar proimage commented on May 28, 2024

Even if you don't have the time to implement this properly, then at least an indication of some sort when one tries to upload an image that it doesn't work yet would be welcome. 😉 Right now it just kinda fails gracefully but silently.

from ckeditor.

magnessjo avatar magnessjo commented on May 28, 2024

I've been exploring adding CKEditor to my Craft sites, and I have some questions and possibly some insights on the image upload issue.

Based on my understanding (the Craft teams knows way better than I do), the 'classic' editor version comes out of the box with the image upload plugin (and its numerous parts -> see note 1). Unfortunately, the Image upload plugin only provides the interactions (which makes sense) and leaves the uploading process to the user who initializing it. In other words, the upload plugins job is to present filesystem dialog so a user can select their Image and show it in the text area (maybe).

Configuration information must be provided to the editor when it's initialized to save files to the local filesystem (or S3 or whatever). CKEditor refers to this configuration step as upload adapters. They list several options:

Easy Image (their homegrown solution) costs a ton but requires no other work from the Craft team. If you wanted to make the current Craft version work with the CDN, you could initialize a version as the Craft docs suggest and pass it to your cloud key. However, it probably isn't ideal for many users (a dealbreaker for me due to cost).

CKFinder is another option. It's new to me. I assume it could be bolted onto the Craft CKEditor plugin (based on a quick scan of the docs). The configuration objects seem straightforward (just provide a uploadUrl string).

Simple Upload seems to be the age-old solution for CKEditor. It seems like the simplest solution for all future users. Based on what I know, I think it could work if Craft could expose an URL that checks to see if someone is logged in and pareses a query string to know what volume to put it into it.

Please let me know if anything doesn't make sense or if I am 100% off base. I will add a few other tickets for additional questions and link a ckeditor builder (of sorts) that might help clarify what I am trying to achieve.

Note 1: The CKEditor image plugin is broken into many different parts (upload, toolbar, style, caption). Some basic documentation on the different features can be found here

from ckeditor.

FreekVR avatar FreekVR commented on May 28, 2024

Yeah would be great to have this, we need a more powerful editor especially for clients looking to edit complex tables (cellspan/colspan) which is not possible with redactor. But with ckeditor they basically cannot upload pictures or link to entries, which is also problematic. So stuck between a rock and a hard place. (Froala Craft plugin is currently also completely broken, unfortunately)

from ckeditor.

theskyfloor avatar theskyfloor commented on May 28, 2024

I agree @FreekVR that its a rough spot. Redactor has never been a great option for me. I would highly recommend checking out Vizy by Verbb, even if you dont plan on using its block patterns its support for images and tables is pretty solid.

from ckeditor.

FreekVR avatar FreekVR commented on May 28, 2024

Hey @theskyfloor thanks for that suggestion.

I did check it out. It has some great wysiwyg functionality apart from the blocks even, but unfortunately no wysiwyg table plugin. Additionally, it is not possible using supertable of something similar to easily format tables with the required features (table heads, dynamic columns, col- and rowspans).

Fortunately it does look like Froala has updated their Craft plugins, which is making it at least functional again, and it now allows for both image (asset) editing AND visually creating HTML tables, so I think we'll be going for that one for the time being.

from ckeditor.

theskyfloor avatar theskyfloor commented on May 28, 2024

Ah you are right! I was using something else with Vizy and got confused about where the table functionality was coming from : )

from ckeditor.

smockensturm avatar smockensturm commented on May 28, 2024

*Unfortunately CKEditor 5 doesn’t have a similar easy way of integrating a file manager, so this is limited to CKE 4 for now.

Hi. Can this file manager config please work with the basic distribution?

https://cdn.ckeditor.com/4.20.0/**basic**/ckeditor.js

from ckeditor.

smockensturm avatar smockensturm commented on May 28, 2024

@smockensturm use the full distribution (or make your own) and configure the toolbar to taste. The file browser plugin is not in the basic distribution.

from ckeditor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.