creative-builds / wsa-magisk Goto Github PK

Steps to reproduce

build manually or try to merge sync from upstream

Expected behaviour

no errors and github actions to work flawlessly

Actual behaviour

theres an upstream changes into the scripts/build.sh and spellcheck workflow which causes the Sync with upstream
and building to fail with github actions

i recommend fixing some codes in accorfance to
https://www.shellcheck.net/wiki/SC2086
https://www.shellcheck.net/wiki/SC2116

like this line on 844 , 35 on scripts/build.sh

from
echo "artifact=$(echo "$artifact_name")" >> $GITHUB_OUTPUT
to
echo "artifact=$artifact_name" >> "$GITHUB_OUTPUT"

this change seems to fix the issue for merging

from
echo "changes=$(git diff --name-only HEAD origin/main)" >> $GITHUB_OUTPUT
to

echo "changes=$(git diff --name-only HEAD origin/main | tr '\n' ' ' )" >> "$GITHUB_OUTPUT"

MagiskOnWSALocal commit full SHA/MagiskOnWSALocal

f29774d

Linux distribution info/Linux

github actions default

Windows version/Windows

10.0.22621.1344

Build Parameters

n/a

Version requirement

• I am using latest commit of MagiskOnWSALocal commit

Logs

Run git diff --name-only HEAD origin/main
.github/workflows/shellcheck.yml
scripts/build.sh
scripts/generateGappsLink.py
scripts/generateKernelSULink.py
scripts/getWSAMainVersion.py
scripts/install_deps.sh
scripts/run.sh
Error: Unable to process file command 'output' successfully.
Error: Invalid format 'scripts/build.sh'

Is your feature request related to a problem?/你的请求是否与某个问题相关？

I'm wanting to test out the Subsystem for Android without the need of Google Play Services, but containing Magisk.

Describe the solution you'd like/描述你想要的解决方案

The releases section should contain a attachment that is just magisk only and no mind-the-gapps

Additional context/其他信息

No response

7d2cca6

Is your feature request related to a problem?

So this repo keeps getting banned due to Actions usage.

Describe the solution you'd like

I'm not too familiar with all this stuff to be honest. That said, do you think Codespaces might be a less dangerous option to offer for anybody who wants to be rebuilding?

Just curious.

Additional context

I built this: https://github.com/nelsonjchen/op-replay-clipper. I use Codespaces as the platform but I'm interested in hearing your thoughts since I definitely don't want to be angering Github either.

Is your feature request related to a problem?

In Github, we have a dll patch to install WSA in Windows 10. Here is the repos of this patch:
https://github.com/cinit/WSAPatch

Describe the solution you'd like

So how about if you update the install.ps1 file to check the Windows version. If the version is 10, copy and paste modifided file to WSA folder then install it.
And can you also add option in Custom Build for people to choose the version for build. Thanks

Additional context

No response

res/values-ptBR/strings.xml

Install device

Originally posted by @Rwadxvv in GermainZ/ActivityForceNewTask#7 (comment)

Steps to reproduce

All the assets contain Removed at the end which can be confusing

Expected behaviour

Remove the 'Removed' at the end, (if possible)

Actual behaviour

Removed exists...

MagiskOnWSALocal commit full SHA/MagiskOnWSALocal

c9f2a8d

Linux distribution info/Linux

None

Windows version/Windows

No need

Build Parameters

No need

Version requirement

• I am using latest commit of MagiskOnWSALocal commit

Logs

No need