cribbl / miteb-frontend Goto Github PK

Description:
While submitting emails, contact numbers, other such input fields, there could be an extra space accidentally or due to autocomplete. This hampers the form fields and the output is not valid.

1. Make sure every input field, before submitting, trims the inputs/free from spaces.
2. trim() could be used.

Describe the bug
Some registration numbers not being accepted, for example, 190911112 is not getting accepted while creating an event.

To Reproduce
Steps to reproduce the behavior:

1. Login as a club.
2. Go to Room Booking page.
3. In the registration number field, enter 190911112.
4. Error Registration number is not valid is shown.

Expected behavior
It should accept this registration number.

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu
• Browser Mozilla Firefox
• Version 70.0.1

Additional context
Add any other context about the problem here.

Use regex for form field validations!

Describe the bug
Club name abbreviation in the profile section should not be editable. It is used as the UID and editing it will break things.

To Reproduce
Steps to reproduce the behavior:

1. Go to /dashboard/profile
2. See Name Abbreviation field

Expected behavior
User should not be able to edit. Similar to email

Screenshots

SO/SC need to block rooms for various reasons. Currently we have been hardcoding blocked rooms into the frontend. We need to find a way to do it interactively and easily.

Exporting approved events for the day is currently trivially handled in ViewBookings.js
Create a separate component for this.

Should probably display an informative toaster when the link to export the approved events is clicked.
Refer Export Events in My Events

Is your feature request related to a problem? Please describe.
Once rejected by an authority the corresponding rooms should be unblocked.

Describe the bug
The before_install script fails for PRs as one is not able to decrypt secrets.tar.enc. It'll work only for me as it uses my encryption keys.

To Reproduce
Steps to reproduce the behavior:

1. Submit/update a PR

Expected behavior
Staging environment variables are used for PRs. These variables will have to be provided in travis environment variables manually.

Is your feature request related to a problem? Please describe.
The SO needs to block rooms for various Departmental and misc. activities. Currently he has to manually ping one of the portal members to block the rooms .

Additional context
Need to address some design issues. Eg. If the room to be blocked has already been booked by some other club.

The DOM doesn't re-render when data from snapshot id fetched and fed through this.props

Add an option 'Portal' under the dropdown of subject while lodging a complaint.

This will facilitate the problems students are facing while using the portal.

Is your feature request related to a problem? Please describe.
There are cases when the FA of a club changes. The existing FA needs to be unassigned, removed from DB entirely and the new FA has to sign up.

Describe the solution you'd like
Build a feature for the SC which allows them to unlink an existing FA from a club. After this, it is same as a new club who's FA hasn't signed up yet.

Additional Context
This might require writing some backend code as well. Please create corresponding issue in the backend if need be.

Current Scenario

Maximum rooms a club can book for an event is 4.

Required Scenario

Maximum rooms a club can book for an event should be limited to 3.

Asked by Ashesh

Is your feature request related to a problem? Please describe.
Currently, the email verification link is sent on the first login attempt. It'd be a better user experience if the email verification link is sent right after signup. The signup message should be changed to let the user know that a verification link has been sent.

Might need work on the backend as well.

Notification Settings in the Profile section seem not important according to the feedback. We can get rid of it.
Yours views? @Arushi1912

Is your feature request related to a problem? Please describe.
Improper monitoring of clubs.

Describe the solution you'd like
The first step of approval/rejection/flag goes through the student council.
Currently, the flow is: FA->AD->SO
Proposed flow: SC->FA->AD->SO

This was asked by Ashesh, Cult Sec, SCMIT

No option to add buttons (view, edit etc) in table in 'My Events' component

1. Switch stepper orientation based on device (desktop / mobile)
2. Validations

Describe the bug
All rooms that have associated events are being shown regardless if they have been approved or not.

Expected behavior
Only show the approved events.

Current Scenario

The maximum date a club can book a room is 1 MONTH from the present date.

Required Scenario

The maximum date a club can book a room should be 20 days from the present date.
eg. Say today is 25th Dec 2018. A club can book a room only uptil 14th Jan 2019 (ie. 20 days ahead)

Reason

There were complaints that some clubs book rooms and not use them, leading to unavailability of rooms.
This was asked by Ashesh, Cultural Secretary of SCMIT (2018 - 19)

specifically the poster, drag and drop facility should be added

Is your feature request related to a problem? Please describe.
Clubs can't cancel booking themselves currently. This feature is required if their event gets cancelled and the rooms need to be freed.

The complaints page looks pretty bare and it would be nice to have a better UI.

The code to download pdfs for export events in my events or approved events in view bookings is hacky. Refactor this.

Describe the solution you'd like
Club should be able to add post event details after their event is held.

Describe the bug
The menu icon which is meant only for the mobile view is displayed on the desktop view too. It is placed on the top left corner. In mobile, it is supposed to open and close the drawer. Drawer is always open on desktop, hence, the icon is not required.

To Reproduce
Steps to reproduce the behavior:

1. Go to '/dashboard'

Expected behavior
The menu icon shouldn't be displayed.

Handle it using this.props.isMobile ?

Screenshots

Describe the bug
The FA is not able to approve events as he/she can't see the pending events.

To Reproduce
This has happened for Project Vision and the Chess club among a few others. Both of these clubs are new users to onboard the portal. The issue might be related to that.
Tested a new club flow in staging. Worked fine.
Need to test on prod.

Describe the bug
Start and End Date columns in My Events say Invalid Date.

To Reproduce
Steps to reproduce the behavior:

1. Go to /dashboard/myEvents
2. See start and end date

Expected behavior
Rather, proper date should be displayed in DD-MM-YYYY format

Screenshots

Is your feature request related to a problem? Please describe.
On signing up no feedback is displayed.

Describe the solution you'd like
A success message asking the user to login would be great.

The approved events pdf file is currently trivially named export.pdf. Rename it to something more informative

You could probaby add the date to the name.

Describe the bug
The Approve clubs component is buggy. Adding an undefined check should solve the issue.

Is your feature request related to a problem? Please describe.
hashHistory uses hasesh (#) in the URL. Use browserHistory instead.

Describe the solution you'd like
Read the npm docs for history and migrate accordingly. A change in almost EVERY file will be required.

Suggested Reading
https://medium.com/@pshrmn/a-little-bit-of-history-f245306f48dd

Is your feature request related to a problem? Please describe.
The security officer needs to get a print of the events happening on any particular day. This printed sheet will be given to the floor in-charges. Backend is ready at /event/generate-daily-events here

Describe the solution you'd like
A print button which prompts for 'Today' ,'Tomorrow' and a Custom date should do.

Note: The functionality should be accessible ONLY by the SO. Check for props.user.isSO

baseURL is used for the hostname of the backend API depending on the environment. It can take 3 values -

1. https://miteb-backend-prod.herokuapp.com when frontend is prod.cribblservices.com
2. https://miteb-backend-dev.herokuapp.com when frontend is staging.cribblservices.com
3. localhost:8000 when frontend is localhost:3000

We could add an environment variable directly pointing to these backend IPs or URLs

Refer existing ReadMe(s) of other open source repositories and draft a suitable one for our repo.

When there are no events under My Events or Approve Events, we show an empty state image along with a one line message.
Need to change the empty state image to empty-state.jpeg from empty-state.gif
GIF rendering is slower and the one which we're currently using isn't of a high definition making it look a bit unprofessional.

Open for alternative images/gifs for empty state.

Is your feature request related to a problem? Please describe.
Add Digital Ocean logo in footer and Readme.md