cricalix / baresipy Goto Github PK

The library assumes that everyone has a gateway to register with. There are use cases where direct peer-to-peer SIP calls are wanted, which baresip supports, and thus the forced registration causes problems.

RV is free for non-commercial use, but any commercial use of this library could trigger commercial use of RV.
Better approach is probably a callback system - feed the SIP library constructor a callback class/function when speech generation is needed. Can document using the python library for RV, or pyFestival, as examples.

Everywhere where handle_call_status is called, there's a separate line of self._call_status = status. Can fold this line into the handle_call_status function with a bit of thought in terms of allowing overrides.

In blocking mode (the default), the code tight-loops waiting for self.ready to change.

self.ready only gets changed by registration succeeding in the existing codebase, which doesn't work when the sip identity doesn't need to be registered.

This causes problems for cases where the library is being used to dial a phone. baresip will complain about the kHz rate of the file, as it's usually too high for the codec that was negotiated (G711u for instance).

It'd be good if the audio rate and channels could be configured, and default to a rate/channel count that's more compatible with a variety of recipient devices (phone or softphone).