cricalix / erddap-feeder Goto Github PK

The cache action wants rustup to be run before it, so that it can use rustc version as cache key.

actions-rust-cross runs rustup, but has no hook to then do cache stuff.

Is cross compiling really needed on this project? If not, simple rustup etc actions might be better. Or, toss the cache - the build only takes 3 minutes.

reqwest supports disabling certificate verification, such as you might have with simple self-signed certificates - .danger_accept_invalid_certs(true). Should add a CLI flag option to enable/disable this functionality, to make it easier to test stuff before deployment.

To make it more useful to other people (or just me), the CLI should load a TOML file with configuration data.
If the file doesn't exist, create it with a sample and exit with a message about editing it
Probably something like

[[mmsi_map]]
mmsi: 0123456789
station_id: A_String OR "A String"

Given this is an axum/tokio based CLI, the data will need to be loaded into the state object and passed around.
confy might be one way to solve the config file storage. It's small, and automatically deals with platforms by using directories.

To be friendlier to running on things like Synology NAS where a GUI is used to configure the image, it would make sense to have args that can be set in the environment and used either directly by the program, or as inputs to a shell script that sets up the execution of the program.

Project needs a license

With the feeder sending everything it gets from the AIS weather message (#2), there will probably be ERDDAP installations that don't want some of the fields, like ice. A filter control in the accepted_packets section should do, listing all the fields to send (or not send), and then filter the resulting query args to drop appropriately.

Instead of the trouble of having to define structs to map each message, just support the whole type 8 message, including fields that might be set to their "unset" value.

TOML config should then look like

erddap_url='https://...'
erddap_key=user_password

[[accepted_packets]]
type=8
dac=200
fid=31
ignore_mmsi=[1,2,3]

[[mmsi_lookup]]
mmsi='12345'
name='Station name'